Skip to content

hswish and hardsigmoid: improve docs #35431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Mar 25, 2020

Stack from ghstack:

Summary:

Resolving @z-a-f's comments on earlier PRs on making
the docblocks easier to read.

Test Plan:

render the new docblocks in http://rst.aaroniles.net/

CI

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D20658668

Summary:

Resolving @z-a-f's comments on earlier PRs on making
the docblocks easier to read.

Test Plan:

render the new docblocks in http://rst.aaroniles.net/

CI

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@vkuzo vkuzo requested a review from apaszke as a code owner March 25, 2020 23:03
vkuzo added a commit that referenced this pull request Mar 25, 2020
Summary:

Resolving @z-a-f's comments on earlier PRs on making
the docblocks easier to read.

Test Plan:

render the new docblocks in http://rst.aaroniles.net/

CI

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 664f0af
Pull Request resolved: #35431
@vkuzo vkuzo requested a review from z-a-f March 25, 2020 23:04
@vkuzo vkuzo self-assigned this Mar 25, 2020
@dr-ci
Copy link

dr-ci bot commented Mar 25, 2020

💊 CircleCI build failures summary and remediations

As of commit 0b6cc8e (more details on the Dr. CI page):


None of the build failures appear to be your fault 💚


  • 1/1 broken upstream at merge base e3daf70 from Mar 27 until Mar 30 (53 commits; b9adbb5 - 35dbc6e)

    Please rebase on the viable/strict branch (expand for instructions)

    If your commit is newer than viable/strict, you can try basing on an older, stable commit:

    git fetch https://github.com/pytorch/pytorch viable/strict
    git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)
    

    If your commit is older than viable/strict:

    git fetch https://github.com/pytorch/pytorch viable/strict
    git rebase FETCH_HEAD
    

    Check out the recency history of this "viable master" tracking branch.


🚧 1 upstream failure:

These were probably caused by upstream breakages:


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 5 times.

Copy link

@z-a-f z-a-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Summary:

Resolving @z-a-f's comments on earlier PRs on making
the docblocks easier to read.

Test Plan:

render the new docblocks in http://rst.aaroniles.net/

CI

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D20658668](https://our.internmc.facebook.com/intern/diff/D20658668)

[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Mar 30, 2020
Summary:

Resolving @z-a-f's comments on earlier PRs on making
the docblocks easier to read.

Test Plan:

render the new docblocks in http://rst.aaroniles.net/

CI

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 3c9e65d
Pull Request resolved: #35431
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in b4c4342.

@facebook-github-bot facebook-github-bot deleted the gh/vkuzo/17/head branch April 4, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants