Skip to content

Conversation

eellison
Copy link
Contributor

This is a follow up from #34520, which removed specialized list ops. This removes templating from list ops.

it also has one minor other change, which is to move aten::len(t[]) -> int to aten::len(Any[]) -> int so that heterogenous tuples can be called with len().

@eellison eellison requested a review from driazati March 31, 2020 18:17
@eellison eellison requested a review from apaszke as a code owner March 31, 2020 18:17
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Mar 31, 2020
@dr-ci
Copy link

dr-ci bot commented Mar 31, 2020

💊 CircleCI build failures summary and remediations

As of commit ecccb66 (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following build failures do not appear to be due to upstream breakages (reran 1 job to discount flakiness):

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_test (1/1)

Step: "Test" (full log | pattern match details) <confirmed not flaky by 2 failures>

Apr 01 00:18:25 AssertionError: 12 not less than or equal to 1e-05 :
Apr 01 00:18:25 ---------------------------------------------------------------------- 
Apr 01 00:18:25 Traceback (most recent call last): 
Apr 01 00:18:25   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 175, in wrapper 
Apr 01 00:18:25     self._join_processes(fn) 
Apr 01 00:18:25   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 285, in _join_processes 
Apr 01 00:18:25     self._check_return_codes(elapsed_time) 
Apr 01 00:18:25   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 324, in _check_return_codes 
Apr 01 00:18:25     self.assertEqual(p.exitcode, first_process.exitcode) 
Apr 01 00:18:25   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 927, in assertEqual 
Apr 01 00:18:25     super(TestCase, self).assertLessEqual(abs(x - y), prec, message) 
Apr 01 00:18:25 AssertionError: 12 not less than or equal to 1e-05 :  
Apr 01 00:18:25  
Apr 01 00:18:25 ---------------------------------------------------------------------- 
Apr 01 00:18:25 Ran 62 tests in 181.701s 
Apr 01 00:18:25  
Apr 01 00:18:25 FAILED (failures=1, skipped=2) 
Apr 01 00:18:25  
Apr 01 00:18:25 Generating XML reports... 
Apr 01 00:18:25 Generated XML report: test-reports/dist-gloo/TEST-DistAutogradTestWithSpawn-20200401001523.xml 
Apr 01 00:18:25 Traceback (most recent call last): 
Apr 01 00:18:25   File "test/run_test.py", line 685, in <module> 

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 30 times.

@eellison eellison requested a review from driazati March 31, 2020 18:43
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@eellison merged this pull request in 1ec0676.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants