Skip to content

Add documentation for FeatureAlphaDropout #36295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

choidongyeon
Copy link

@choidongyeon choidongyeon commented Apr 9, 2020

These changes add documentation for FeatureAlphaDropout, based on a need raised in an issue by @ssnl (Issue #9886). Fixes #37436.

@choidongyeon choidongyeon requested a review from apaszke as a code owner April 9, 2020 02:54
@dr-ci
Copy link

dr-ci bot commented Apr 9, 2020

💊 CI failures summary and remediations

As of commit 7a35e87 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 70 times.

@choidongyeon
Copy link
Author

Note: flake8 is failing because of lint errors in test/jit/test_python_ir.py.

@zhangguanheng66 zhangguanheng66 added module: docs Related to our documentation, both in docs/ and docblocks module: nn Related to torch.nn triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Apr 9, 2020
@choidongyeon
Copy link
Author

Hey @apaszke, could you let me know what you think? :)

Copy link
Collaborator

@ssnl ssnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than two minor points. please fix. thanks!

@choidongyeon
Copy link
Author

lgtm other than two minor points. please fix. thanks!

Thanks for taking another look! Just updated the PR. Hopefully I got it right this time. :)

Copy link
Collaborator

@ssnl ssnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

Copy link
Collaborator

@ssnl ssnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh you need to fix the submodule change

@choidongyeon
Copy link
Author

choidongyeon commented Apr 14, 2020

oh you need to fix the submodule change

Hey, what does this mean?

Edit: I think I figured it out. I really hope I did this correctly...

@ssnl ssnl force-pushed the doc-featurealphadropout branch from 2b2203c to 2bb10b4 Compare April 14, 2020 06:14
@ssnl
Copy link
Collaborator

ssnl commented Apr 14, 2020

no worries, i fixed it.

@pytorchbot merge this please

@pytorchbot pytorchbot added the merge-this-please Was marked for merge with @pytorchbot merge this please label Apr 14, 2020
@choidongyeon
Copy link
Author

@apaszke could you please take a look at this so we can close this out? :)

@apaszke
Copy link
Contributor

apaszke commented Apr 18, 2020

@choidongyeon sorry, but I'm not at FB so I can't speed up merging this PR. @soumith?

@zou3519
Copy link
Contributor

zou3519 commented May 8, 2020

There's a test failure (https://circleci.com/gh/pytorch/pytorch/5381793?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link).

@choidongyeon could you remove feature_alpha_dropout from

test_namespace(torch.nn.functional, 'assert_int_or_pair', 'feature_alpha_dropout')
?

May 06 22:36:38 ======================================================================
May 06 22:36:38 FAIL [0.013s]: test_doc (__main__.TestTorch)
May 06 22:36:38 ----------------------------------------------------------------------
May 06 22:36:38 Traceback (most recent call last):
May 06 22:36:38   File "test_torch.py", line 192, in test_doc
May 06 22:36:38     test_namespace(torch.nn.functional, 'assert_int_or_pair', 'feature_alpha_dropout')
May 06 22:36:38   File "test_torch.py", line 158, in test_namespace
May 06 22:36:38     'it from the skipped list in TestTorch.test_doc'.format(full_name))
May 06 22:36:38 AssertionError: True is not false : New docs have been added for module.feature_alpha_dropout, please remove it from the skipped list in TestTorch.test_doc

Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes b/c of test failure

@choidongyeon
Copy link
Author

Thanks for pointing that out @zou3519 !

@zou3519
Copy link
Contributor

zou3519 commented May 8, 2020

@choidongyeon I'm seeing some merge conflicts in the tests. This is usually caused by the branch being too far behind master (it look like it's around two days old, which really isn't that old...). Could you rebase onto master and force push to the branch?

After a rebase and the tests run I think this should be good to go. I can handle merging this when it's ready.

@choidongyeon
Copy link
Author

@zou3519 Oh oops I merged master instead of rebase, hope that's okay.. Thanks for taking a look!

@zou3519
Copy link
Contributor

zou3519 commented May 8, 2020

@choidongyeon yeah, that's fine. I had some quick comments while reading through the docs; sorry I should have done the read through when I requested changes initially.

Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let's wait for the tests to pass

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@zou3519 merged this pull request in ca2206d.

@choidongyeon choidongyeon deleted the doc-featurealphadropout branch May 28, 2020 22:20
@vadimkantorov
Copy link
Contributor

Somehow, it didn't work. Docs are not available online:
image

@vadimkantorov
Copy link
Contributor

Probably because it misses automodule directive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-this-please Was marked for merge with @pytorchbot merge this please Merged module: docs Related to our documentation, both in docs/ and docblocks module: nn Related to torch.nn open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature_alpha_dropout is not documented
9 participants