make vendor match with this implementation #36302
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: used 1/sqrt(x) vs rsqrt(x) Test Plan: tested with the seed from testwarden 1586230820 tested without the seed Differential Revision: D20939672 fbshipit-source-id: 8409dea4e4f3a82e2786c681a3780f151e37de61
|
This pull request was exported from Phabricator. Differential Revision: D20939672 |
💊 CircleCI build failures summary and remediationsAs of commit 5687a00 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no CircleCI failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 1 time. |
|
This pull request has been merged in 423b014. |
ashishfarmer
pushed a commit
to ashishfarmer/pytorch
that referenced
this pull request
Apr 13, 2020
Summary: Pull Request resolved: pytorch#36302 used 1/sqrt(x) vs rsqrt(x) Test Plan: tested with the seed from testwarden 1586230820 tested without the seed Differential Revision: D20939672 fbshipit-source-id: c7be030c4ae42e78765edda2ce1ad2e213a46030
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: used 1/sqrt(x) vs rsqrt(x)
Test Plan:
tested with the seed from testwarden 1586230820
tested without the seed
Differential Revision: D20939672