[PyTorch Numeric Suite] Add module level comparison #36669
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add module level comparison API. Differential Revision: [D21045393](https://our.internmc.facebook.com/intern/diff/D21045393/) [ghstack-poisoned]
hx89
pushed a commit
that referenced
this pull request
Apr 15, 2020
Add module level comparison API. Differential Revision: [D21045393](https://our.internmc.facebook.com/intern/diff/D21045393/) ghstack-source-id: 102210159 Pull Request resolved: #36669
💊 Build failures summary and remediationsAs of commit 82f1975 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 22 times. |
Add module level comparison API. Differential Revision: [D21045393](https://our.internmc.facebook.com/intern/diff/D21045393/) [ghstack-poisoned]
hx89
pushed a commit
that referenced
this pull request
Apr 17, 2020
Pull Request resolved: #36669 Add module level comparison API. ghstack-source-id: 102385175 Differential Revision: [D21045393](https://our.internmc.facebook.com/intern/diff/D21045393/)
| q_module._modules[key] = value | ||
|
|
||
|
|
||
| def compare_model_stub(float_model, q_model, module_swap_list, data, Logger=Logger): |
There was a problem hiding this comment.
Wondering if we need this as a top level function or keep this as an internal/test only function and move it to the test code.
There was a problem hiding this comment.
Maybe we can keep it as top level function since it's easy for user to use as a one-liner to quickly check the model accuracy?
There was a problem hiding this comment.
Sure, as long as we have the building blocks as user facing functions, we are ok.
raghuramank100
suggested changes
Apr 18, 2020
Add module level comparison API. Differential Revision: [D21045393](https://our.internmc.facebook.com/intern/diff/D21045393/) [ghstack-poisoned]
|
Address comments. |
Add module level comparison API. Differential Revision: [D21045393](https://our.internmc.facebook.com/intern/diff/D21045393/) [ghstack-poisoned]
hx89
pushed a commit
that referenced
this pull request
Apr 21, 2020
Pull Request resolved: #36669 Add module level comparison API. ghstack-source-id: 102589374 Differential Revision: [D21045393](https://our.internmc.facebook.com/intern/diff/D21045393/)
raghuramank100
approved these changes
Apr 22, 2020
Add module level comparison API. Differential Revision: [D21045393](https://our.internmc.facebook.com/intern/diff/D21045393/) [ghstack-poisoned]
hx89
pushed a commit
that referenced
this pull request
Apr 22, 2020
Pull Request resolved: #36669 Add module level comparison API. ghstack-source-id: 102672767 Differential Revision: [D21045393](https://our.internmc.facebook.com/intern/diff/D21045393/)
Add module level comparison API. Differential Revision: [D21045393](https://our.internmc.facebook.com/intern/diff/D21045393/) [ghstack-poisoned]
hx89
pushed a commit
that referenced
this pull request
Apr 22, 2020
Pull Request resolved: #36669 Add module level comparison API. ghstack-source-id: 102713666 Differential Revision: [D21045393](https://our.internmc.facebook.com/intern/diff/D21045393/)
Add module level comparison API. Differential Revision: [D21045393](https://our.internmc.facebook.com/intern/diff/D21045393/) [ghstack-poisoned]
hx89
pushed a commit
that referenced
this pull request
Apr 23, 2020
Pull Request resolved: #36669 Add module level comparison API. ghstack-source-id: 102761562 Differential Revision: [D21045393](https://our.internmc.facebook.com/intern/diff/D21045393/)
Add module level comparison API. Differential Revision: [D21045393](https://our.internmc.facebook.com/intern/diff/D21045393/) [ghstack-poisoned]
hx89
pushed a commit
that referenced
this pull request
Apr 23, 2020
Pull Request resolved: #36669 Add module level comparison API. ghstack-source-id: 102802362 Differential Revision: [D21045393](https://our.internmc.facebook.com/intern/diff/D21045393/)
|
This pull request has been merged in fba9b9a. |
hx89
pushed a commit
that referenced
this pull request
Apr 24, 2020
Pull Request resolved: #36669 Add module level comparison API. ghstack-source-id: 102851307 Differential Revision: [D21231719](https://our.internmc.facebook.com/intern/diff/D21231719/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Add module level comparison API.
Differential Revision: D21045393