Skip to content

Conversation

ngimel
Copy link
Collaborator

@ngimel ngimel commented Apr 18, 2020

Try reenabling bfloat16 masked_select, see it windows tests pass.

@ngimel ngimel requested a review from mruberry April 18, 2020 04:58
@ngimel
Copy link
Collaborator Author

ngimel commented Apr 18, 2020

cc @kurtamohler, previously failing windows test is passing.

Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ngimel ngimel changed the title [WIP] reenable bfloat16 masked_select reenable bfloat16 masked_select Apr 19, 2020
@facebook-github-bot
Copy link
Contributor

@ngimel merged this pull request in 1b3741a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants