[quant][graphmode] Move numerics changing passes before finalize #37514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This is to constrain all numerics changing operations in insert quant dequant pass Test Plan: python test/test_quantization.py TestQuantizeScriptJitPasses Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
facebook-github-bot
added
the
oncall: jit
…nalize" Summary: This is to constrain all numerics changing operations in insert quant dequant pass Test Plan: python test/test_quantization.py TestQuantizeScriptJitPasses Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
💊 Build failures summary and remediationsAs of commit f310ab2 (more details on the Dr. CI page): ✅ None of the build failures appear to be your fault 💚
1 job timed out:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 33 times. |
…nalize" Summary: This is to constrain all numerics changing operations in insert quant dequant pass Test Plan: python test/test_quantization.py TestQuantizeScriptJitPasses Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
…nalize" Summary: This is to constrain all numerics changing operations in insert quant dequant pass Test Plan: python test/test_quantization.py TestQuantizeScriptJitPasses Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
…nalize" Summary: This is to constrain all numerics changing operations in insert quant dequant pass Test Plan: python test/test_quantization.py TestQuantizeScriptJitPasses Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
supriyar
reviewed
Apr 30, 2020
| @@ -1133,7 +1107,6 @@ def forward(self, x): | |||
| model = torch.jit.script(M()).eval() | |||
| model = quantize_script(model, qconfig_dict, _test_only_eval_fn, [data], inplace=False, debug=True) | |||
| FileCheck().check_not("quantized::conv2d") \ | |||
| .check("CallMethod") \ | |||
There was a problem hiding this comment.
Why do we not check for CallMethod anymore?
There was a problem hiding this comment.
yeah, we'll inline the graph in convert so CallMethod from sub module is gone
supriyar
reviewed
Apr 30, 2020
supriyar
reviewed
Apr 30, 2020
| row->elements().at(0).toStringRef()); | ||
| row->elements().at(0).toStringRef() == "operators", | ||
| "Expected operators but found ", | ||
| row->elements().at(0).toStringRef()); |
There was a problem hiding this comment.
Should this change be here?
There was a problem hiding this comment.
this is clang format changes, got this when I run clang-format-all.py
…nalize" Summary: This is to constrain all numerics changing operations in insert quant dequant pass Test Plan: python test/test_quantization.py TestQuantizeScriptJitPasses Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
…nalize" Summary: This is to constrain all numerics changing operations in insert quant dequant pass Test Plan: python test/test_quantization.py TestQuantizeScriptJitPasses Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
…nalize" Summary: This is to constrain all numerics changing operations in insert quant dequant pass Test Plan: python test/test_quantization.py TestQuantizeScriptJitPasses Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
…nalize" Summary: This is to constrain all numerics changing operations in insert quant dequant pass Test Plan: python test/test_quantization.py TestQuantizeScriptJitPasses Reviewers: . Subscribers: Tasks: Tags: [ghstack-poisoned]
raghuramank100
approved these changes
May 1, 2020
|
This pull request has been merged in 5e0a24f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
This is to constrain all numerics changing operations in insert quant dequant pass
Test Plan:
python test/test_quantization.py TestQuantizeScriptJitPasses
Reviewers:
.
Subscribers:
Tasks:
Tags:
Differential Revision: D21364008