Update assertion in MHA forward to support FP16 training #37539
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Bug fix Test Plan: This passed fbtranslate local integration test when I toggle fp16 to true on GPU. akinh is adding another unit test at library level. myleott is there an existing unit test in fairseq for preventing this kind of fp16 issues from happening? Differential Revision: D21311505 fbshipit-source-id: a8f0f9cccf59077e600052aa733d6da794485da0
|
This pull request was exported from Phabricator. Differential Revision: D21311505 |
|
This pull request has been merged in 5bb9357. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Bug fix
Test Plan:
This passed fbtranslate local integration test when I toggle fp16 to true on GPU.
akinh is adding another unit test at library level. myleott is there an existing unit test in fairseq for preventing this kind of fp16 issues from happening?
Differential Revision: D21311505