Fix max_pool2d for returning wrong shape with return_indices=True on cuda #38992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xwang233
changed the title
💊 CI failures summary and remediationsAs of commit e32253d (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 7 times. |
ngimel
reviewed
May 26, 2020
test/test_nn.py
Outdated
| def test_max_pool2d_indices(self, device): | ||
| def helper(n, c, h, w, ks): | ||
| if h is None: | ||
| x = torch.randn(n, c, w, device='cuda', dtype=torch.float, requires_grad=True) |
There was a problem hiding this comment.
the test (while correct) is confusing - 3d input is chw, not ncw (that it, it lacks batch dimension, not one of the spatial dimensions).
There was a problem hiding this comment.
Oops, seems like I confused that with the unsqueeze(2) in max_pool1d. Will fix. Thanks!
ngimel
approved these changes
May 26, 2020
There was a problem hiding this comment.
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ezyang
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #38986
The current code only resizes pooling output but forget to resize indices as well.