Implement CUDA_KERNEL_ASSERT for MSVC #39218
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngimel
approved these changes
May 29, 2020
|
@peterjc123 awesome! Maybe with asserts enabled on windows this test Line 1726 in 0e8c65f |
|
I'll try to re-enable it. |
|
cc @gchanan Maybe we should get this into v1.5.1. |
malfet
reviewed
May 29, 2020
malfet
approved these changes
May 29, 2020
💊 CI failures summary and remediationsAs of commit 4a1e54a (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 4 times. |
malfet
approved these changes
May 29, 2020
There was a problem hiding this comment.
@malfet is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
peterjc123
added a commit
to peterjc123/pytorch
that referenced
this pull request
May 30, 2020
Summary: Tested locally on CPU/GPU + Debug/Release. Pull Request resolved: pytorch#39218 Differential Revision: D21786500 Pulled By: malfet fbshipit-source-id: 7e871003d3509436952932b5ff3599e36bb8f205 # Conflicts: # test/test_cuda.py
This was referenced May 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested locally on CPU/GPU + Debug/Release.