[android] test_app example linking to pytorch_android aar content #39587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 5, 2020
💊 CI failures summary and remediationsAs of commit 5808499 (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
… aar content" [ghstack-poisoned]
IvanKobzarev
changed the title
…content" [ghstack-poisoned]
…content" [ghstack-poisoned]
…content" [ghstack-poisoned]
…content" [ghstack-poisoned]
…content" [ghstack-poisoned]
…content" [ghstack-poisoned]
…content" [ghstack-poisoned]
…content" [ghstack-poisoned]
ljk53
reviewed
Jun 17, 2020
|
|
||
| #include "jni.h" | ||
|
|
||
| #include <ATen/NativeFunctions.h> |
There was a problem hiding this comment.
why do we need this header? I think we should still encourage people to use <torch/script.h>
android/test_app/app/build.gradle
Outdated
| } | ||
| signingConfigs { | ||
| config { | ||
| storeFile file("testapp.keystore") |
There was a problem hiding this comment.
curious: what's the common practice to handle keystore for demo/test app? I found this but not sure whether it's worth the trouble for test app: https://stackoverflow.com/questions/44911547/where-to-store-android-keystore-file-for-cirlceci-build
There was a problem hiding this comment.
Yes, we can do it more securely for CircleCI. That keystore is completely dummy, there is no 'PyTorch' and 'Facebook' inside it.
I think if somebody will start signing his app with this keystore there should not be any problems.
| ALOGI("%s %s", m, os.str().c_str()); | ||
| } | ||
|
|
||
| struct JITCallGuard { |
There was a problem hiding this comment.
I feel it's probably helpful to copy the comment in your README here as well as people might copy/paste the code snippet without reading readme, e.g.:
To load torchscript model for mobile we need some special setup which is placed in `struct JITCallGuard` in this example. It may change in future, you can track the latest changes keeping an eye in our [pytorch android jni code]([https://github.com/pytorch/pytorch/blob/master/android/pytorch_android/src/main/cpp/pytorch_jni_jit.cpp#L28)
also, maybe change "need some special setup" to a bit more context, e.g. "need set these guards because mobile build doesn't support features like autograd for smaller build size"
…content" Example of using direct linking to pytorch_jni library from aar and updating android/README.md with the tutorial how to do it. Adding `nativeBuild` dimension to `test_app`, using direct aar dependencies, as headers packaging is not landed yet, excluding `nativeBuild` from building by default for CI. Additional change to `scripts/build_pytorch_android.sh`: Skipping clean task here as android gradle plugin 3.3.2 exteralNativeBuild has problems with it when abiFilters are specified. Will be returned back in the following diffs with upgrading of gradle and android gradle plugin versions. [ghstack-poisoned]
…content" Example of using direct linking to pytorch_jni library from aar and updating android/README.md with the tutorial how to do it. Adding `nativeBuild` dimension to `test_app`, using direct aar dependencies, as headers packaging is not landed yet, excluding `nativeBuild` from building by default for CI. Additional change to `scripts/build_pytorch_android.sh`: Skipping clean task here as android gradle plugin 3.3.2 exteralNativeBuild has problems with it when abiFilters are specified. Will be returned back in the following diffs with upgrading of gradle and android gradle plugin versions. [ghstack-poisoned]
…content" Example of using direct linking to pytorch_jni library from aar and updating android/README.md with the tutorial how to do it. Adding `nativeBuild` dimension to `test_app`, using direct aar dependencies, as headers packaging is not landed yet, excluding `nativeBuild` from building by default for CI. Additional change to `scripts/build_pytorch_android.sh`: Skipping clean task here as android gradle plugin 3.3.2 exteralNativeBuild has problems with it when abiFilters are specified. Will be returned back in the following diffs with upgrading of gradle and android gradle plugin versions. [ghstack-poisoned]
Closed
ljk53
approved these changes
Jun 18, 2020
…content" Example of using direct linking to pytorch_jni library from aar and updating android/README.md with the tutorial how to do it. Adding `nativeBuild` dimension to `test_app`, using direct aar dependencies, as headers packaging is not landed yet, excluding `nativeBuild` from building by default for CI. Additional change to `scripts/build_pytorch_android.sh`: Skipping clean task here as android gradle plugin 3.3.2 exteralNativeBuild has problems with it when abiFilters are specified. Will be returned back in the following diffs with upgrading of gradle and android gradle plugin versions. [ghstack-poisoned]
…content" Example of using direct linking to pytorch_jni library from aar and updating android/README.md with the tutorial how to do it. Adding `nativeBuild` dimension to `test_app`, using direct aar dependencies, as headers packaging is not landed yet, excluding `nativeBuild` from building by default for CI. Additional change to `scripts/build_pytorch_android.sh`: Skipping clean task here as android gradle plugin 3.3.2 exteralNativeBuild has problems with it when abiFilters are specified. Will be returned back in the following diffs with upgrading of gradle and android gradle plugin versions. Differential Revision: [D22118945](https://our.internmc.facebook.com/intern/diff/D22118945) [ghstack-poisoned]
…content" Example of using direct linking to pytorch_jni library from aar and updating android/README.md with the tutorial how to do it. Adding `nativeBuild` dimension to `test_app`, using direct aar dependencies, as headers packaging is not landed yet, excluding `nativeBuild` from building by default for CI. Additional change to `scripts/build_pytorch_android.sh`: Skipping clean task here as android gradle plugin 3.3.2 exteralNativeBuild has problems with it when abiFilters are specified. Will be returned back in the following diffs with upgrading of gradle and android gradle plugin versions. Differential Revision: [D22118945](https://our.internmc.facebook.com/intern/diff/D22118945) [ghstack-poisoned]
…content" Example of using direct linking to pytorch_jni library from aar and updating android/README.md with the tutorial how to do it. Adding `nativeBuild` dimension to `test_app`, using direct aar dependencies, as headers packaging is not landed yet, excluding `nativeBuild` from building by default for CI. Additional change to `scripts/build_pytorch_android.sh`: Skipping clean task here as android gradle plugin 3.3.2 exteralNativeBuild has problems with it when abiFilters are specified. Will be returned back in the following diffs with upgrading of gradle and android gradle plugin versions. Differential Revision: [D22118945](https://our.internmc.facebook.com/intern/diff/D22118945) [ghstack-poisoned]
|
@IvanKobzarev merged this pull request in 52a2adb. |
xwang233
pushed a commit
to xwang233/pytorch
that referenced
this pull request
Jun 20, 2020
…torch#39587) Summary: Pull Request resolved: pytorch#39587 Example of using direct linking to pytorch_jni library from aar and updating android/README.md with the tutorial how to do it. Adding `nativeBuild` dimension to `test_app`, using direct aar dependencies, as headers packaging is not landed yet, excluding `nativeBuild` from building by default for CI. Additional change to `scripts/build_pytorch_android.sh`: Skipping clean task here as android gradle plugin 3.3.2 exteralNativeBuild has problems with it when abiFilters are specified. Will be returned back in the following diffs with upgrading of gradle and android gradle plugin versions. Test Plan: Imported from OSS Differential Revision: D22118945 Pulled By: IvanKobzarev fbshipit-source-id: 31c54b49b1f262cbe5f540461d3406f74851db6c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Example of using direct linking to pytorch_jni library from aar and updating android/README.md with the tutorial how to do it.
Adding
nativeBuilddimension totest_app, using direct aar dependencies, as headers packaging is not landed yet, excludingnativeBuildfrom building by default for CI.Additional change to
scripts/build_pytorch_android.sh:Skipping clean task here as android gradle plugin 3.3.2 exteralNativeBuild has problems with it when abiFilters are specified.
Will be returned back in the following diffs with upgrading of gradle and android gradle plugin versions.
Differential Revision: D22118945