Skip to content

Add rpc.async_execution support for rpc.remote on script functions #39758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

mrshenli
Copy link
Contributor

@mrshenli mrshenli commented Jun 9, 2020

Stack from ghstack:

Differential Revision: D21963789

mrshenli added a commit that referenced this pull request Jun 9, 2020
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jun 9, 2020
@rohan-varma rohan-varma self-requested a review June 10, 2020 05:53
@dr-ci
Copy link

dr-ci bot commented Jun 10, 2020

💊 CI failures summary and remediations

As of commit 4425093 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 4 times.

mrshenli added a commit that referenced this pull request Jun 10, 2020
@mrshenli mrshenli requested a review from rohan-varma June 10, 2020 18:17
Copy link
Member

@rohan-varma rohan-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the previous comments I had!

@facebook-github-bot
Copy link
Contributor

@mrshenli merged this pull request in 3fb1e73.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants