Delete Python <= 3.5 specific checks from the code #39879
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
oncall: jit
|
Let me know if it's better to split it into a series of small PRs |
💊 CI failures summary and remediationsAs of commit 4d261a7 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 23 times. |
seemethere
approved these changes
Jun 11, 2020
Python-2 is no longer supported, so map would always return an iterator
malfet
force-pushed
the
malfet/delete-py2-codepaths
branch
from
886defe to
2448ed4
Compare
malfet
force-pushed
the
malfet/delete-py2-codepaths
branch
from
2448ed4 to
20efff6
Compare
There was a problem hiding this comment.
@malfet is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@malfet is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
xwang233
pushed a commit
to xwang233/pytorch
that referenced
this pull request
Jun 20, 2020
Summary: Remove PY3 and PY34 checks from `torch/testing/_internal/common_utils.py` Remove PY35 global var from `torch.jit.annotations` Always call `try_get_real_signature` in `torch/jit/annotations.py` Use `map` instead of `imap`, since Python-2 is no longer support, so map is always lazy. Remove all pre Python-3.6 checks from `torch/_six.py` and `torch/_appdirs.py` Pull Request resolved: pytorch#39879 Differential Revision: D22037811 Pulled By: malfet fbshipit-source-id: af0c79f976569c2059d39ecb49c6b8285161734f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove PY3 and PY34 checks from
torch/testing/_internal/common_utils.pyRemove PY35 global var from
torch.jit.annotationsAlways call
try_get_real_signatureintorch/jit/annotations.pyUse
mapinstead ofimap, since Python-2 is no longer support, so map is always lazy.Remove all pre Python-3.6 checks from
torch/_six.pyandtorch/_appdirs.py