Skip to content

Add typing for _CudaStreamBase and _CudaEventBase classes #40256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Jun 18, 2020

No description provided.

@malfet malfet requested review from ezyang, rgommers and seemethere June 18, 2020 23:56
@malfet malfet changed the title Malfet/ cuda stream base typing Add typing for _CudaStreamBase and _CudaEventBase classes Jun 18, 2020
@dr-ci
Copy link

dr-ci bot commented Jun 19, 2020

💊 CI failures summary and remediations

As of commit baee6e6 (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-build-x86_32 (1/1)

Step: "pytorch android gradle build only x86_32 (for PR)" (full log | diagnosis details | 🔁 rerun)

Jun 19 16:24:18 ./.circleci/scripts/build_android_gradle.sh: line 73: /opt/gradle/gradle-6.5/bin/gradle: No such file or directory
Jun 19 16:24:18 ANDROID_NDK_HOME=/opt/ndk 
Jun 19 16:24:18 INSTALLED_DB= 
Jun 19 16:24:18 _=/usr/bin/env 
Jun 19 16:24:18 + export GRADLE_LOCAL_PROPERTIES=/var/lib/jenkins/workspace/android/local.properties 
Jun 19 16:24:18 + GRADLE_LOCAL_PROPERTIES=/var/lib/jenkins/workspace/android/local.properties 
Jun 19 16:24:18 + rm -f /var/lib/jenkins/workspace/android/local.properties 
Jun 19 16:24:18 + echo sdk.dir=/opt/android/sdk 
Jun 19 16:24:18 + echo ndk.dir=/opt/ndk 
Jun 19 16:24:18 + echo cmake.dir=/usr/local 
Jun 19 16:24:18 + /opt/gradle/gradle-6.5/bin/gradle -p android assembleRelease --debug --stacktrace -PABI_FILTERS=x86 --offline 
Jun 19 16:24:18 ./.circleci/scripts/build_android_gradle.sh: line 73: /opt/gradle/gradle-6.5/bin/gradle: No such file or directory 

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 4 times.

Copy link
Collaborator

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only two minor comments. Thanks @malfet

@malfet malfet force-pushed the malfet/_CudaStreamBase-typing branch from fd3e5d5 to baee6e6 Compare June 19, 2020 15:34
@rgommers rgommers added the module: typing Related to mypy type annotations label Jun 19, 2020
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@malfet malfet deleted the malfet/_CudaStreamBase-typing branch June 19, 2020 21:06
@facebook-github-bot
Copy link
Contributor

@malfet merged this pull request in b670ff2.

xwang233 pushed a commit to xwang233/pytorch that referenced this pull request Jun 20, 2020
)

Summary: Pull Request resolved: pytorch#40256

Differential Revision: D22139369

Pulled By: malfet

fbshipit-source-id: c7f4f8709700eb85d971ad504dd3552e311cb58d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged module: typing Related to mypy type annotations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants