quant docs: clean up hardswish #40323
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleans up the naming and the function param docs for quantized hardswish. Remove redundant docstrings and link to floating point modules instead. Test plan: * build the docs on Mac OS * verify that every link works as expected [ghstack-poisoned]
jerryzh168
approved these changes
Jun 20, 2020
💊 CI failures summary and remediationsAs of commit f7bad97 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 16 times. |
jerryzh168
reviewed
Jun 20, 2020
jerryzh168
reviewed
Jun 20, 2020
| @@ -193,7 +193,7 @@ Basic activations are supported. | |||
| * :meth:`~torch.nn.functional.adaptive_avg_pool2d` - Adaptive average pooling | |||
| * :meth:`~torch.nn.functional.avg_pool2d` - Average pooling | |||
| * :meth:`~torch.nn.functional.interpolate` - Interpolation | |||
| * :meth:`~torch.nn.functional.hardswish` - Hard Swish | |||
| * :meth:`~torch.nn.functional.hardswish` - Hardswish | |||
There was a problem hiding this comment.
actually why are these method? I feel it makes more sense for these to be func
There was a problem hiding this comment.
not sure if there is any difference in the generated docs. If this is important, might be good to be a separate PR on the entire file, so that it's consistent within the file
There was a problem hiding this comment.
yeah, it should be changed in a separate PR I think
Cleans up the naming and the function param docs for quantized hardswish. Remove redundant docstrings and link to floating point modules instead. Test plan: * build the docs on Mac OS * verify that every link works as expected [ghstack-poisoned]
Cleans up the naming and the function param docs for quantized hardswish. Remove redundant docstrings and link to floating point modules instead. Test plan: * build the docs on Mac OS * verify that every link works as expected [ghstack-poisoned]
This was referenced Jun 20, 2020
Cleans up the naming and the function param docs for quantized hardswish. Remove redundant docstrings and link to floating point modules instead. Test plan: * build the docs on Mac OS * verify that every link works as expected Differential Revision: [D22152638](https://our.internmc.facebook.com/intern/diff/D22152638) [ghstack-poisoned]
raghuramank100
approved these changes
Jun 22, 2020
Cleans up the naming and the function param docs for quantized hardswish. Remove redundant docstrings and link to floating point modules instead. Test plan: * build the docs on Mac OS * verify that every link works as expected Differential Revision: [D22152638](https://our.internmc.facebook.com/intern/diff/D22152638) [ghstack-poisoned]
Cleans up the naming and the function param docs for quantized hardswish. Remove redundant docstrings and link to floating point modules instead. Test plan: * build the docs on Mac OS * verify that every link works as expected Differential Revision: [D22152638](https://our.internmc.facebook.com/intern/diff/D22152638) [ghstack-poisoned]
Cleans up the naming and the function param docs for quantized hardswish. Remove redundant docstrings and link to floating point modules instead. Test plan: * build the docs on Mac OS * verify that every link works as expected Differential Revision: [D22152638](https://our.internmc.facebook.com/intern/diff/D22152638) [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Cleans up the naming and the function param docs for quantized hardswish.
Remove redundant docstrings and link to floating point modules instead.
Test plan:
Differential Revision: D22152638