[vulkan] max_pool2d #41379
Closed
[vulkan] max_pool2d #41379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Jul 14, 2020
Closed
[ghstack-poisoned]
This was referenced Jul 14, 2020
Closed
💊 CI failures summary and remediationsAs of commit f1083fc (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 25 times. |
[ghstack-poisoned]
Differential Revision: [D22754944](https://our.internmc.facebook.com/intern/diff/D22754944) [ghstack-poisoned]
Differential Revision: [D22754944](https://our.internmc.facebook.com/intern/diff/D22754944) [ghstack-poisoned]
Differential Revision: [D22754944](https://our.internmc.facebook.com/intern/diff/D22754944) [ghstack-poisoned]
Differential Revision: [D22754944](https://our.internmc.facebook.com/intern/diff/D22754944) [ghstack-poisoned]
Differential Revision: [D22754944](https://our.internmc.facebook.com/intern/diff/D22754944) [ghstack-poisoned]
This was referenced Jul 28, 2020
Differential Revision: [D22754944](https://our.internmc.facebook.com/intern/diff/D22754944) [ghstack-poisoned]
AshkanAliabadi
approved these changes
Aug 3, 2020
| TORCH_CHECK( | ||
| kernel_size.size() == 1 || kernel_size.size() == 2, | ||
| "Vulkan max_pool2d: kernel_size must either be a single int, or a tuple of two ints") | ||
| const int kH = safe_downcast<int, int64_t>(kernel_size[0]); |
There was a problem hiding this comment.
This usage is technically correct but template argument deduction can deduce the second template parameter (i.e. source type) passed as a function argument, so this will work as well:
const int kH = safe_downcast<int>(kernel_size[0]);
| self.dim() == 4, "Vulkan max_pool2d is implemented for 4-dim input"); | ||
|
|
||
| const auto& x = vtensor_from_vulkan(self); | ||
| auto inputSize = self.sizes(); |
There was a problem hiding this comment.
Is this const? If so auto does not imply const.
| uConstBlock; | ||
|
|
||
| #define UP_DIV(x, y) (((x) + (y)-1) / (y)) | ||
| #define FLT_MAX 3.402823466e+38 |
There was a problem hiding this comment.
If these are used in other shaders please consider moving to a common location.
Differential Revision: [D22754944](https://our.internmc.facebook.com/intern/diff/D22754944) [ghstack-poisoned]
Differential Revision: [D22754944](https://our.internmc.facebook.com/intern/diff/D22754944) [ghstack-poisoned]
|
@IvanKobzarev merged this pull request in b852168. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D22754944