[TensorExpr] Make tensorOrConstant non-templatized function. #42202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we used the template in order to be able to take both `std::vector<ExprHandle>` and `std::vector<VarHandle>`. However, semantics of this function tells that the only allowed option should be the former one: we're specifying indices for the tensor access we want to generate. While it could be convenient to avoid conversion from vector of vars to a vector of exprs at the callsites, it makes the code less explicit and thus more difficult to reason about. [ghstack-poisoned]
This was referenced Jul 28, 2020
facebook-github-bot
added
the
oncall: jit
Currently we used the template in order to be able to take both `std::vector<ExprHandle>` and `std::vector<VarHandle>`. However, semantics of this function tells that the only allowed option should be the former one: we're specifying indices for the tensor access we want to generate. While it could be convenient to avoid conversion from vector of vars to a vector of exprs at the callsites, it makes the code less explicit and thus more difficult to reason about. Differential Revision: [D22806429](https://our.internmc.facebook.com/intern/diff/D22806429) [ghstack-poisoned]
ZolotukhinM
pushed a commit
that referenced
this pull request
Jul 29, 2020
Currently we used the template in order to be able to take both `std::vector<ExprHandle>` and `std::vector<VarHandle>`. However, semantics of this function tells that the only allowed option should be the former one: we're specifying indices for the tensor access we want to generate. While it could be convenient to avoid conversion from vector of vars to a vector of exprs at the callsites, it makes the code less explicit and thus more difficult to reason about. ghstack-source-id: 6ce1944 Pull Request resolved: #42202
💊 CI failures summary and remediationsAs of commit 063a85f (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 18 times. |
Currently we used the template in order to be able to take both `std::vector<ExprHandle>` and `std::vector<VarHandle>`. However, semantics of this function tells that the only allowed option should be the former one: we're specifying indices for the tensor access we want to generate. While it could be convenient to avoid conversion from vector of vars to a vector of exprs at the callsites, it makes the code less explicit and thus more difficult to reason about. Differential Revision: [D22806429](https://our.internmc.facebook.com/intern/diff/D22806429) [ghstack-poisoned]
ZolotukhinM
pushed a commit
that referenced
this pull request
Jul 29, 2020
…functions. Currently we used the template in order to be able to take both `std::vector<ExprHandle>` and `std::vector<VarHandle>`. However, semantics of this function tells that the only allowed option should be the former one: we're specifying indices for the tensor access we want to generate. While it could be convenient to avoid conversion from vector of vars to a vector of exprs at the callsites, it makes the code less explicit and thus more difficult to reason about. ghstack-source-id: dd17562 Pull Request resolved: #42202
Currently we used the template in order to be able to take both `std::vector<ExprHandle>` and `std::vector<VarHandle>`. However, semantics of this function tells that the only allowed option should be the former one: we're specifying indices for the tensor access we want to generate. While it could be convenient to avoid conversion from vector of vars to a vector of exprs at the callsites, it makes the code less explicit and thus more difficult to reason about. Differential Revision: [D22806429](https://our.internmc.facebook.com/intern/diff/D22806429) [ghstack-poisoned]
ZolotukhinM
pushed a commit
that referenced
this pull request
Jul 30, 2020
…functions. Currently we used the template in order to be able to take both `std::vector<ExprHandle>` and `std::vector<VarHandle>`. However, semantics of this function tells that the only allowed option should be the former one: we're specifying indices for the tensor access we want to generate. While it could be convenient to avoid conversion from vector of vars to a vector of exprs at the callsites, it makes the code less explicit and thus more difficult to reason about. ghstack-source-id: 64a07ce Pull Request resolved: #42202
Currently we used the template in order to be able to take both `std::vector<ExprHandle>` and `std::vector<VarHandle>`. However, semantics of this function tells that the only allowed option should be the former one: we're specifying indices for the tensor access we want to generate. While it could be convenient to avoid conversion from vector of vars to a vector of exprs at the callsites, it makes the code less explicit and thus more difficult to reason about. Differential Revision: [D22806429](https://our.internmc.facebook.com/intern/diff/D22806429) [ghstack-poisoned]
ZolotukhinM
pushed a commit
that referenced
this pull request
Jul 30, 2020
…functions. Currently we used the template in order to be able to take both `std::vector<ExprHandle>` and `std::vector<VarHandle>`. However, semantics of this function tells that the only allowed option should be the former one: we're specifying indices for the tensor access we want to generate. While it could be convenient to avoid conversion from vector of vars to a vector of exprs at the callsites, it makes the code less explicit and thus more difficult to reason about. ghstack-source-id: 3a22bb6 Pull Request resolved: #42202
added 2 commits
July 31, 2020 15:57
Currently we used the template in order to be able to take both `std::vector<ExprHandle>` and `std::vector<VarHandle>`. However, semantics of this function tells that the only allowed option should be the former one: we're specifying indices for the tensor access we want to generate. While it could be convenient to avoid conversion from vector of vars to a vector of exprs at the callsites, it makes the code less explicit and thus more difficult to reason about. Differential Revision: [D22806429](https://our.internmc.facebook.com/intern/diff/D22806429) [ghstack-poisoned]
Currently we used the template in order to be able to take both `std::vector<ExprHandle>` and `std::vector<VarHandle>`. However, semantics of this function tells that the only allowed option should be the former one: we're specifying indices for the tensor access we want to generate. While it could be convenient to avoid conversion from vector of vars to a vector of exprs at the callsites, it makes the code less explicit and thus more difficult to reason about. Differential Revision: [D22806429](https://our.internmc.facebook.com/intern/diff/D22806429) [ghstack-poisoned]
|
@ZolotukhinM merged this pull request in dcc4d11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Currently we used the template in order to be able to take both
std::vector<ExprHandle>andstd::vector<VarHandle>. However,semantics of this function tells that the only allowed option should be
the former one: we're specifying indices for the tensor access we want
to generate. While it could be convenient to avoid conversion from
vector of vars to a vector of exprs at the callsites, it makes the code
less explicit and thus more difficult to reason about.
Differential Revision: D22806429