Skip to content

[Resending] [ONNX] Add eliminate_unused_items pass #42743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 32 commits into from
Closed

[Resending] [ONNX] Add eliminate_unused_items pass #42743

wants to merge 32 commits into from

Conversation

KsenijaS
Copy link
Contributor

@KsenijaS KsenijaS commented Aug 7, 2020

This PR:

  • Adds eliminate_unused_items pass that removes unused inputs and initializers.
  • Fixes run_embed_params function so it doesn't export unnecessary parameters.
  • Removes test_modifying_params in test_verify since it's no longer needed.

KsenijaS added 28 commits May 19, 2020 14:56
@KsenijaS
add pass eliminate_unused_items
10c3a71
@KsenijaS
fix build
5ecec61
@KsenijaS
refactor code
fa1f1e6
@KsenijaS
add tests
4280ce6
@KsenijaS
remove test
6048f7d
@KsenijaS
fix flake8 errors
7d56957
@KsenijaS
run clang format
1db9dfb
@KsenijaS
Merge https://github.com/pytorch/pytorch into unused
605b889
@KsenijaS
update constant fold pass
61abec6
@KsenijaS
Merge https://github.com/pytorch/pytorch into unused
78312b3
@KsenijaS
clang format
0cebe1e
@KsenijaS
fix buils
47b6a33
@KsenijaS
add newline
d758548
@KsenijaS
don't add unused parameters
ac61c2b
@KsenijaS
clang format
f746ece
@KsenijaS
remove test_modifying_params
7713890
@KsenijaS
Merge https://github.com/pytorch/pytorch into unused
41bc9fb
@KsenijaS
add test_modifying_params
e135eae
@KsenijaS
remove comment
295550f
@KsenijaS
add comment for the pass
e72fb8c
@KsenijaS
Merge https://github.com/pytorch/pytorch into unused
ba3cd7f
@KsenijaS
fix clang-tidy
7af6ee3
@KsenijaS
clang format
cd4eb95
@KsenijaS
fix build
4ddf336
@KsenijaS
use kFloat instead kHalf
159d4da
@KsenijaS
add enum
944ba35
@KsenijaS
Merge https://github.com/pytorch/pytorch into unused
b72eb36
@KsenijaS
fix merge conflict
d3af475
@KsenijaS KsenijaS requested a review from apaszke as a code owner August 7, 2020 19:04
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Aug 7, 2020
@dr-ci
Copy link

dr-ci bot commented Aug 7, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 839f6f2 (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 23 times.

@KsenijaS
Copy link
Contributor Author

KsenijaS commented Aug 9, 2020

@houseroad can you please take a look? Thanks!

houseroad
houseroad reviewed Aug 10, 2020
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase and fix the build issue?

@smessmer smessmer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 10, 2020
@KsenijaS
Copy link
Contributor Author

@houseroad I don't think that CI failure is caused by PR changes.

facebook-github-bot
facebook-github-bot reviewed Aug 11, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

houseroad
houseroad approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@facebook-github-bot
Copy link
Contributor

@houseroad merged this pull request in e845b0a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@houseroad houseroad houseroad approved these changes

@apaszke apaszke Awaiting requested review from apaszke

Assignees

No one assigned

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@KsenijaS @facebook-github-bot @houseroad @smessmer @pytorchbot @mruberry