[JIT] Propagate type sharing setting to submodule compilation #44226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** At present, the `share_types` argument to `create_script_module` is used to decide whether to reuse a previously created type for a top-level module that has not yet been compiled. However, that setting does not apply to the compilation of submodules of the top-level module; types are still reused if possible. This commit modifies `create_script_module` so that the `share_types` flag is honoured during submodule compilation as well. **Test Plan** This commit adds a unit test to `TestTypeSharing` that checks that submodule types are not shared or reused when `share_types` is set to `False`. **Fixes** This commit fixes #43605. [ghstack-poisoned]
SplitInfinity
pushed a commit
that referenced
this pull request
Sep 4, 2020
**Summary** At present, the `share_types` argument to `create_script_module` is used to decide whether to reuse a previously created type for a top-level module that has not yet been compiled. However, that setting does not apply to the compilation of submodules of the top-level module; types are still reused if possible. This commit modifies `create_script_module` so that the `share_types` flag is honoured during submodule compilation as well. **Test Plan** This commit adds a unit test to `TestTypeSharing` that checks that submodule types are not shared or reused when `share_types` is set to `False`. **Fixes** This commit fixes #43605. ghstack-source-id: c1dc278 Pull Request resolved: #44226
facebook-github-bot
added
the
oncall: jit
💊 CI failures summary and remediationsAs of commit ccfaf4f (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 14 times. |
…ion" **Summary** At present, the `share_types` argument to `create_script_module` is used to decide whether to reuse a previously created type for a top-level module that has not yet been compiled. However, that setting does not apply to the compilation of submodules of the top-level module; types are still reused if possible. This commit modifies `create_script_module` so that the `share_types` flag is honoured during submodule compilation as well. **Test Plan** This commit adds a unit test to `TestTypeSharing` that checks that submodule types are not shared or reused when `share_types` is set to `False`. **Fixes** This commit fixes #43605. [ghstack-poisoned]
SplitInfinity
pushed a commit
that referenced
this pull request
Sep 9, 2020
**Summary** At present, the `share_types` argument to `create_script_module` is used to decide whether to reuse a previously created type for a top-level module that has not yet been compiled. However, that setting does not apply to the compilation of submodules of the top-level module; types are still reused if possible. This commit modifies `create_script_module` so that the `share_types` flag is honoured during submodule compilation as well. **Test Plan** This commit adds a unit test to `TestTypeSharing` that checks that submodule types are not shared or reused when `share_types` is set to `False`. **Fixes** This commit fixes #43605. ghstack-source-id: 00e7531 Pull Request resolved: #44226
…ion" **Summary** At present, the `share_types` argument to `create_script_module` is used to decide whether to reuse a previously created type for a top-level module that has not yet been compiled. However, that setting does not apply to the compilation of submodules of the top-level module; types are still reused if possible. This commit modifies `create_script_module` so that the `share_types` flag is honoured during submodule compilation as well. **Test Plan** This commit adds a unit test to `TestTypeSharing` that checks that submodule types are not shared or reused when `share_types` is set to `False`. **Fixes** This commit fixes #43605. [ghstack-poisoned]
SplitInfinity
pushed a commit
that referenced
this pull request
Sep 9, 2020
**Summary** At present, the `share_types` argument to `create_script_module` is used to decide whether to reuse a previously created type for a top-level module that has not yet been compiled. However, that setting does not apply to the compilation of submodules of the top-level module; types are still reused if possible. This commit modifies `create_script_module` so that the `share_types` flag is honoured during submodule compilation as well. **Test Plan** This commit adds a unit test to `TestTypeSharing` that checks that submodule types are not shared or reused when `share_types` is set to `False`. **Fixes** This commit fixes #43605. ghstack-source-id: ec07e33 Pull Request resolved: #44226
gmagogsfm
approved these changes
Sep 9, 2020
…ion" **Summary** At present, the `share_types` argument to `create_script_module` is used to decide whether to reuse a previously created type for a top-level module that has not yet been compiled. However, that setting does not apply to the compilation of submodules of the top-level module; types are still reused if possible. This commit modifies `create_script_module` so that the `share_types` flag is honoured during submodule compilation as well. **Test Plan** This commit adds a unit test to `TestTypeSharing` that checks that submodule types are not shared or reused when `share_types` is set to `False`. **Fixes** This commit fixes #43605. Differential Revision: [D23602371](https://our.internmc.facebook.com/intern/diff/D23602371) [ghstack-poisoned]
SplitInfinity
pushed a commit
that referenced
this pull request
Sep 9, 2020
**Summary** At present, the `share_types` argument to `create_script_module` is used to decide whether to reuse a previously created type for a top-level module that has not yet been compiled. However, that setting does not apply to the compilation of submodules of the top-level module; types are still reused if possible. This commit modifies `create_script_module` so that the `share_types` flag is honoured during submodule compilation as well. **Test Plan** This commit adds a unit test to `TestTypeSharing` that checks that submodule types are not shared or reused when `share_types` is set to `False`. **Fixes** This commit fixes #43605. ghstack-source-id: b257a0e Pull Request resolved: #44226
Codecov Report
@@ Coverage Diff @@
## gh/splitinfinity/38/base #44226 +/- ##
============================================================
- Coverage 68.00% 68.00% -0.01%
============================================================
Files 382 382
Lines 49391 49394 +3
============================================================
+ Hits 33586 33588 +2
- Misses 15805 15806 +1
Continue to review full report at Codecov.
|
|
@SplitInfinity merged this pull request in 89ac30a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary
At present, the
share_typesargument tocreate_script_moduleis usedto decide whether to reuse a previously created type for a top-level
module that has not yet been compiled. However, that setting does not apply
to the compilation of submodules of the top-level module; types are
still reused if possible.
This commit modifies
create_script_moduleso that theshare_typesflag is honoured during submodule compilation as well.
Test Plan
This commit adds a unit test to
TestTypeSharingthat checks thatsubmodule types are not shared or reused when
share_typesis set toFalse.Fixes
This commit fixes #43605.
Differential Revision: D23602371