-
Notifications
You must be signed in to change notification settings - Fork 25k
Autograd functional API should enable_grad #47543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CI failures summary and remediationsAs of commit 3833c39 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
❄️ 1 failure tentatively classified as flakybut reruns have not yet been triggered to confirm:
|
More efficient implementation creating graphs only when its necessary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you wanted to commit the .nojekyll
file right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I don't want :) so i removed the file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
You need to fix the lint though
And you can rebase on top of the viable/strict
branch to make sure you don't get any CI failures due to a broken master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for removing the jekyll file.
btw the jekyll file is back in the PR and should be removed before merging. |
bd7bd96
to
4dde815
Compare
Codecov Report
@@ Coverage Diff @@
## master #47543 +/- ##
==========================================
- Coverage 77.65% 77.64% -0.01%
==========================================
Files 1869 1869
Lines 182327 182348 +21
==========================================
+ Hits 141583 141591 +8
- Misses 40744 40757 +13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small update to reduce code duplication, good to go otherwise.
Thanks for the rebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iramazanli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@iramazanli merged this pull request in f364e49. |
Summary: Fixes pytorch#44640 Pull Request resolved: pytorch#47543 Reviewed By: albanD Differential Revision: D26965136 Pulled By: iramazanli fbshipit-source-id: 1dd46b9402bb670c0e165db684712e26c1a2036f
Fixes #44640