Skip to content

Conversation

robieta
Copy link

@robieta robieta commented Nov 12, 2020

Stack from ghstack:

Differential Revision: D25199263

@dr-ci
Copy link

dr-ci bot commented Nov 12, 2020

💊 CI failures summary and remediations

As of commit 57bfc98 (more details on the Dr. CI page):


None of the CI failures appear to be your fault 💚



🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

Since your merge base is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 23 times.

@robieta
Copy link
Author

robieta commented Nov 12, 2020

@pytorchbot retest this please

@@ -186,6 +186,9 @@ std::string show_config() {
}

std::string get_cxx_flags() {
#if defined(FBCODE_CAFFE2)
TORCH_CHECK(false, "CXX_FLAGS is only for OSS build.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error message is not as descriptive as it could be. Why is CXX_FLAGS only for OSS build?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buck does not populate the `CXX_FLAGS` field of Caffe2 build options. As a result, get_cxx_flags is OSS only.?

@facebook-github-bot
Copy link
Contributor

@robieta merged this pull request in 27905df.

@facebook-github-bot facebook-github-bot deleted the gh/robieta/1/head branch December 5, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants