-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Expose CXX_FLAGS through __config__ #47861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 57bfc98 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 fixed upstream failure:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
@pytorchbot retest this please |
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Differential Revision: [D25199263](https://our.internmc.facebook.com/intern/diff/D25199263) [ghstack-poisoned]
Differential Revision: [D25199263](https://our.internmc.facebook.com/intern/diff/D25199263) [ghstack-poisoned]
aten/src/ATen/Version.cpp
Outdated
@@ -186,6 +186,9 @@ std::string show_config() { | |||
} | |||
|
|||
std::string get_cxx_flags() { | |||
#if defined(FBCODE_CAFFE2) | |||
TORCH_CHECK(false, "CXX_FLAGS is only for OSS build."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This error message is not as descriptive as it could be. Why is CXX_FLAGS only for OSS build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buck does not populate the `CXX_FLAGS` field of Caffe2 build options. As a result, get_cxx_flags is OSS only.
?
Differential Revision: [D25199263](https://our.internmc.facebook.com/intern/diff/D25199263) [ghstack-poisoned]
Stack from ghstack:
Differential Revision: D25199263