Replace constexpr with CONSTEXPR_EXCEPT_WIN_CUDA #48717
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
cla signed
oncall: jit
ezyang
approved these changes
Dec 2, 2020
There was a problem hiding this comment.
@datumbox has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Codecov Report
@@ Coverage Diff @@
## master #48717 +/- ##
=======================================
Coverage 80.83% 80.83%
=======================================
Files 1859 1859
Lines 200633 200633
=======================================
+ Hits 162177 162184 +7
+ Misses 38456 38449 -7 |
This was referenced Dec 4, 2020
|
Unlanding due to #48835 it seems to have broken other downstream Windows |
|
This pull request has been reverted by eb43e12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48716