Generalize some TensorIterator consumers to take TensorIteratorBase #48727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
This was referenced Dec 2, 2020
Closed
💊 CI failures summary and remediationsAs of commit 8e534f4 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 9 times. |
…ratorBase" Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
This was referenced Dec 2, 2020
…ratorBase" Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
ngimel
approved these changes
Dec 2, 2020
Codecov Report
@@ Coverage Diff @@
## gh/ezyang/880/base #48727 +/- ##
===================================================
Coverage 80.83% 80.83%
===================================================
Files 1860 1860
Lines 200668 200668
===================================================
+ Hits 162214 162218 +4
+ Misses 38454 38450 -4 |
bhosmer
approved these changes
Dec 2, 2020
ezyang
added a commit
to ezyang/pytorch
that referenced
this pull request
Dec 3, 2020
Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: 581fd72 Pull Request resolved: pytorch#48727
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D25278033