Add sinc operator #48740
Add sinc operator #48740
Conversation
💊 CI failures summary and remediationsAs of commit 50cd680 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 97 times. |
Codecov Report
@@ Coverage Diff @@
## master #48740 +/- ##
==========================================
- Coverage 80.61% 80.61% -0.01%
==========================================
Files 1879 1879
Lines 203539 203549 +10
==========================================
+ Hits 164074 164081 +7
- Misses 39465 39468 +3 |
…to implement-sinc
There was a problem hiding this comment.
Nice work, @soulitzer! Just some minor nits for cleanup before merging. Thanks for being so diligent with adding an OpInfo for sinc.
|
The asan_test2 build failure is unrelated to this PR. |
There was a problem hiding this comment.
@soulitzer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@soulitzer merged this pull request in bbc7143. |
|
This pull request has been reverted by 7767dcf. |
There was a problem hiding this comment.
@soulitzer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@soulitzer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Implements the sinc operator. See https://numpy.org/doc/stable/reference/generated/numpy.sinc.html  Pull Request resolved: pytorch#48740 Reviewed By: izdeby Differential Revision: D25564477 Pulled By: soulitzer fbshipit-source-id: 13f36a2b84dadfb4fd1442a2a40a3a3246cbaecb
Summary: Implements the sinc operator. See https://numpy.org/doc/stable/reference/generated/numpy.sinc.html  Pull Request resolved: pytorch#48740 Reviewed By: ezyang Differential Revision: D25597565 Pulled By: soulitzer fbshipit-source-id: 6dbcf282ee4eba34930bc9e5c85c0c5e79cf0322
Implements the sinc operator.
See https://numpy.org/doc/stable/reference/generated/numpy.sinc.html