[1.7.1] torch: Stop using _nt_quote_args from distutils (#48618) #48768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: They removed the specific function in Python 3.9 so we should just remake the function here and use our own instead of relying on hidden functions from the stdlib Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Fixes pytorch#48617 Pull Request resolved: pytorch#48618 Reviewed By: samestep Differential Revision: D25230281 Pulled By: seemethere fbshipit-source-id: 57216af40a4ae4dc8bafcf40d2eb3ba793b9b6e2 (cherry picked from commit 780f2b9) Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
seemethere
requested review from
ezyang,
fmassa,
goldsborough and
soumith
as code owners
walterddr
approved these changes
Dec 3, 2020
💊 CI failures summary and remediationsAs of commit 55d3ff8 (more details on the Dr. CI page):
XLA failureJob pytorch_xla_linux_bionic_py3_6_clang9_test is failing. Please create an issue with title prefixed by Extra GitHub checks: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 2 times. |
|
Tests passed on upstream PR going to go ahead and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
They removed the specific function in Python 3.9 so we should just
remake the function here and use our own instead of relying on hidden
functions from the stdlib
Signed-off-by: Eli Uriegas eliuriegas@fb.com
Fixes #48617
Pull Request resolved: #48618
Reviewed By: samestep
Differential Revision: D25230281
Pulled By: seemethere
fbshipit-source-id: 57216af40a4ae4dc8bafcf40d2eb3ba793b9b6e2
(cherry picked from commit 780f2b9)
Signed-off-by: Eli Uriegas eliuriegas@fb.com
Fixes #{issue number}