Scopes 0.3.1 backport #5153
Merged
Scopes 0.3.1 backport #5153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set missing temporary scope in callPySymbolicMethod * Use expected traces in all scope tests
* Fix tracking of tracing scopes during ONNX pass * Use ResourceGuard to manage setting a temporary current scope in Graph * Add tests for ONNX pass scopes * Remove unused num_classes argument
It's correct only when the new graph owns the same scope tree as the original one. We can end up with dangling pointers otherwise.
|
Thanks @ezyang, I was wondering what was going on... |
|
@lantiga is this locally passing all tests? (including onnx tests) if so this is good enough for me. |
|
Yep, I ran all tests from the sh script on my Mac. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the request for backporting scopes to 0.3.1 in #4821.