Fix for incorrect usage of logging in torch/distributed/distributed_c10d.py #51739

szmigacz · 2021-02-04T20:34:24Z

…10d.py

facebook-github-bot · 2021-02-04T20:34:30Z

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot · 2021-02-04T20:34:33Z

💊 CI failures summary and remediations

As of commit 9f670b2 (more details on the Dr. CI page):

3/7 failures introduced in this PR
4/7 broken upstream at merge base 2d305b9 on Feb 04 from 12:06pm to 1:19pm

🕵️ 3 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_xla_linux_bionic_py3_6_clang9_build (1/3)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.

CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/windows_build_definitions.py
Auto-merging .circleci/cimodel/data/windows_build_definitions.py
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/simple/docker_definitions.py
Auto-merging .circleci/cimodel/data/simple/docker_definitions.py
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_data.py
Auto-merging .circleci/cimodel/data/pytorch_build_data.py
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/dimensions.py
Auto-merging .circleci/cimodel/data/dimensions.py
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

pytorch_linux_xenial_py3_6_gcc5_4_build (2/3)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.

CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/windows_build_definitions.py
Auto-merging .circleci/cimodel/data/windows_build_definitions.py
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/simple/docker_definitions.py
Auto-merging .circleci/cimodel/data/simple/docker_definitions.py
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_data.py
Auto-merging .circleci/cimodel/data/pytorch_build_data.py
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/dimensions.py
Auto-merging .circleci/cimodel/data/dimensions.py
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

pytorch_linux_xenial_cuda9_2_cudnn7_py3_gcc5_4_build (3/3)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.

CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/windows_build_definitions.py
Auto-merging .circleci/cimodel/data/windows_build_definitions.py
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/simple/docker_definitions.py
Auto-merging .circleci/cimodel/data/simple/docker_definitions.py
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_data.py
Auto-merging .circleci/cimodel/data/pytorch_build_data.py
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/dimensions.py
Auto-merging .circleci/cimodel/data/dimensions.py
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

🚧 4 fixed upstream failures:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test1 on Feb 04 from 12:06pm to 1:17pm (2d305b9 - 1e2df9e)
- 🔁 rerun
pytorch_linux_bionic_py3_8_gcc9_coverage_test1 on Feb 04 from 12:06pm to 1:16pm (2d305b9 - 7d00aec)
- 🔁 rerun
pytorch_linux_xenial_py3_clang5_asan_test1 on Feb 04 from 12:06pm to 1:19pm (2d305b9 - de9364a)
- 🔁 rerun
pytorch_linux_bionic_py3_6_clang9_test on Feb 04 from 12:06pm to 12:52pm (2d305b9 - 7d00aec)
- 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

facebook-github-bot · 2021-02-04T21:07:52Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

ngimel · 2021-02-10T22:49:30Z

Can you add a test for this behavior, similar maybe to failing case in #51428?

… initialized after calling init_process_group

szmigacz · 2021-02-11T17:22:11Z

I added a simple unit test, I'm not sure if I picked the best location for this test case, please verify.

pritamdamania87

Thanks for fixing this!

facebook-github-bot

@pritamdamania87 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2021-02-24T06:32:55Z

This pull request has been merged in 075bbe0.

H-Huang · 2021-02-24T13:37:30Z

This PR broke flake8 CI test due to import logging being defined twice, so I am reverting.

@szmigacz could you rebase and resubmit this PR?

facebook-github-bot · 2021-02-24T15:07:54Z

This pull request has been reverted by b56f59e.

…10d.py (pytorch#51739) Summary: Fixes pytorch#51428 Pull Request resolved: pytorch#51739 Reviewed By: bdhirsh Differential Revision: D26599390 fbshipit-source-id: d822658076f7b08ebfde3dc9994159539490fda0

…stributed_c10d.py (#52757) Summary: Resubmit of #51739 Fixes #51428 Pull Request resolved: #52757 Reviewed By: cbalioglu Differential Revision: D26646843 fbshipit-source-id: df4962ef86ea465307e39878860b9fbbcc958d52

Fix for incorrect usage of logging in torch/distributed/distributed_c…

e680ee5

…10d.py

szmigacz requested review from mingzhe09088, mrshenli, pritamdamania87, rohan-varma and zhaojuanmao as code owners February 4, 2021 20:34

facebook-github-bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Feb 4, 2021

szmigacz mentioned this pull request Feb 4, 2021

init_process_group changes the behavior of logging #51428

Closed

pytorchbot added the open source label Feb 4, 2021

facebook-github-bot added the cla signed label Feb 4, 2021

zhangguanheng66 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 5, 2021

Added a test to check if logging default handler is not automatically…

9f670b2

… initialized after calling init_process_group

pritamdamania87 approved these changes Feb 23, 2021

View reviewed changes

facebook-github-bot reviewed Feb 23, 2021

View reviewed changes

facebook-github-bot closed this in 075bbe0 Feb 24, 2021

facebook-github-bot added the Merged label Feb 24, 2021

facebook-github-bot added the Reverted label Feb 24, 2021

szmigacz mentioned this pull request Feb 24, 2021

[Resubmit] Fix for incorrect usage of logging in torch/distributed/distributed_c10d.py #52757

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix for incorrect usage of logging in torch/distributed/distributed_c10d.py #51739

Fix for incorrect usage of logging in torch/distributed/distributed_c10d.py #51739

Uh oh!

szmigacz commented Feb 4, 2021

Uh oh!

facebook-github-bot commented Feb 4, 2021

Uh oh!

facebook-github-bot commented Feb 4, 2021 •

edited

Loading

Uh oh!

facebook-github-bot commented Feb 4, 2021

Uh oh!

ngimel commented Feb 10, 2021

Uh oh!

szmigacz commented Feb 11, 2021

Uh oh!

pritamdamania87 left a comment

Uh oh!

facebook-github-bot left a comment

Uh oh!

facebook-github-bot commented Feb 24, 2021

Uh oh!

H-Huang commented Feb 24, 2021

Uh oh!

facebook-github-bot commented Feb 24, 2021

Uh oh!

Uh oh!

Fix for incorrect usage of logging in torch/distributed/distributed_c10d.py #51739

Fix for incorrect usage of logging in torch/distributed/distributed_c10d.py #51739

Uh oh!

Conversation

szmigacz commented Feb 4, 2021

Uh oh!

facebook-github-bot commented Feb 4, 2021

Action Required

Process

Uh oh!

facebook-github-bot commented Feb 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

🕵️ 3 new failures recognized by patterns

pytorch_xla_linux_bionic_py3_6_clang9_build (1/3)

pytorch_linux_xenial_py3_6_gcc5_4_build (2/3)

pytorch_linux_xenial_cuda9_2_cudnn7_py3_gcc5_4_build (3/3)

🚧 4 fixed upstream failures:

Uh oh!

facebook-github-bot commented Feb 4, 2021

Uh oh!

ngimel commented Feb 10, 2021

Uh oh!

szmigacz commented Feb 11, 2021

Uh oh!

pritamdamania87 left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Feb 24, 2021

Uh oh!

H-Huang commented Feb 24, 2021

Uh oh!

facebook-github-bot commented Feb 24, 2021

Uh oh!

Uh oh!

facebook-github-bot commented Feb 4, 2021 •

edited

Loading