Skip to content

Use c10::irange for great good #52153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

r-barnes
Copy link
Contributor

Differential Revision: D26407087

@facebook-github-bot facebook-github-bot added cla signed oncall: jit Add this issue/PR to JIT oncall triage queue labels Feb 11, 2021
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 11, 2021

💊 CI failures summary and remediations

As of commit c48a9eb (more details on the Dr. CI page):



🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Feb 24 01:56:05 [E request_callback_no_python.cpp:656] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future
Feb 24 01:56:05 At:
Feb 24 01:56:05   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(120): serialize
Feb 24 01:56:05   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(172): serialize
Feb 24 01:56:05 
Feb 24 01:56:05 [E request_callback_no_python.cpp:656] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future
Feb 24 01:56:05 
Feb 24 01:56:05 At:
Feb 24 01:56:05   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(120): serialize
Feb 24 01:56:05   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(172): serialize
Feb 24 01:56:05 
Feb 24 01:56:05 [E request_callback_no_python.cpp:656] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future
Feb 24 01:56:05 
Feb 24 01:56:05 At:
Feb 24 01:56:05   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(120): serialize
Feb 24 01:56:05   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(172): serialize
Feb 24 01:56:05 
Feb 24 01:56:06 ok (2.150s)
Feb 24 01:56:07   test_return_future_remote (__main__.ProcessGroupRpcTestWithSpawn) ... RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend.
Feb 24 01:56:07 RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend.
Feb 24 01:56:07 RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend.
Feb 24 01:56:07 RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend.

1 job timed out:

  • pytorch_linux_xenial_py3_6_gcc5_4_test

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_linux_bionic_py3_8_gcc9_coverage_test1 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun) ❄️

Feb 24 02:34:17 RuntimeError: Process 1 terminated or timed out after 100.07383608818054 seconds
Feb 24 02:34:17 ======================================================================
Feb 24 02:34:17 ERROR [100.129s]: test_backward_node_failure_python_udf (__main__.TensorPipeDistAutogradTestWithSpawn)
Feb 24 02:34:17 ----------------------------------------------------------------------
Feb 24 02:34:17 Traceback (most recent call last):
Feb 24 02:34:17   File "/opt/conda/lib/python3.8/site-packages/torch/testing/_internal/common_distributed.py", line 286, in wrapper
Feb 24 02:34:17     self._join_processes(fn)
Feb 24 02:34:17   File "/opt/conda/lib/python3.8/site-packages/torch/testing/_internal/common_distributed.py", line 418, in _join_processes
Feb 24 02:34:17     self._check_return_codes(elapsed_time)
Feb 24 02:34:17   File "/opt/conda/lib/python3.8/site-packages/torch/testing/_internal/common_distributed.py", line 466, in _check_return_codes
Feb 24 02:34:17     raise RuntimeError('Process {} terminated or timed out after {} seconds'.format(i, elapsed_time))
Feb 24 02:34:17 RuntimeError: Process 1 terminated or timed out after 100.07383608818054 seconds
Feb 24 02:34:17 
Feb 24 02:34:17 ----------------------------------------------------------------------
Feb 24 02:34:17 Ran 411 tests in 1428.729s
Feb 24 02:34:17 
Feb 24 02:34:17 FAILED (errors=1, skipped=66)
Feb 24 02:34:17 
Feb 24 02:34:17 Generating XML reports...
Feb 24 02:34:17 Generated XML report: test-reports/dist-gloo/TEST-TensorPipeDdpComparisonTestWithSpawn-20210224021028.xml
Feb 24 02:34:17 Generated XML report: test-reports/dist-gloo/TEST-TensorPipeDdpUnderDistAutogradTestWithSpawn-20210224021028.xml
Feb 24 02:34:17 Generated XML report: test-reports/dist-gloo/TEST-TensorPipeDistAutogradTestWithSpawn-20210224021028.xml

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D26407087

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #52153 (75ba309) into master (64847c7) will decrease coverage by 0.19%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master   #52153      +/-   ##
==========================================
- Coverage   80.79%   80.59%   -0.20%     
==========================================
  Files        1972     1956      -16     
  Lines      216093   214417    -1676     
==========================================
- Hits       174586   172812    -1774     
- Misses      41507    41605      +98     

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D26407087

Summary: Pull Request resolved: pytorch#52153

Test Plan: Sandcastle

Reviewed By: ngimel

Differential Revision: D26407087

fbshipit-source-id: 1850df5759bf7640455a9af860594e1b456a7178
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D26407087

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 29c4290.

aocsa pushed a commit to Quansight/pytorch that referenced this pull request Mar 15, 2021
Summary: Pull Request resolved: pytorch#52153

Test Plan: Sandcastle

Reviewed By: ngimel

Differential Revision: D26407087

fbshipit-source-id: ea8ce1c17299cb9d89621e4a39f31edc2faa9fd6
xsacha pushed a commit to xsacha/pytorch that referenced this pull request Mar 31, 2021
Summary: Pull Request resolved: pytorch#52153

Test Plan: Sandcastle

Reviewed By: ngimel

Differential Revision: D26407087

fbshipit-source-id: ea8ce1c17299cb9d89621e4a39f31edc2faa9fd6
kere-nel pushed a commit to kere-nel/pytorch that referenced this pull request Apr 30, 2021
Summary: Pull Request resolved: pytorch#52153

Test Plan: Sandcastle

Reviewed By: ngimel

Differential Revision: D26407087

fbshipit-source-id: ea8ce1c17299cb9d89621e4a39f31edc2faa9fd6
jjsjann123 pushed a commit to jjsjann123/nvfuser that referenced this pull request Oct 29, 2022
Summary: Pull Request resolved: pytorch/pytorch#52153

Test Plan: Sandcastle

Reviewed By: ngimel

Differential Revision: D26407087

fbshipit-source-id: ea8ce1c17299cb9d89621e4a39f31edc2faa9fd6
jjsjann123 pushed a commit to jjsjann123/nvfuser that referenced this pull request Nov 10, 2022
Summary: Pull Request resolved: pytorch/pytorch#52153

Test Plan: Sandcastle

Reviewed By: ngimel

Differential Revision: D26407087

fbshipit-source-id: ea8ce1c17299cb9d89621e4a39f31edc2faa9fd6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed fb-exported Merged oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants