Skip to content

ns for fx: make unshadowed activation comparison work for N models #52357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

ns for fx: make unshadowed activation comparison work for N models #52357

wants to merge 5 commits into from

Conversation

vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Feb 17, 2021 •
edited
Loading

Stack from ghstack:

Summary:

Refactor the NS for FX compare unshadowed activations API to be able
to work on N models and do arbitrary matching strategies.

We factor out a util which takes a model and a list of
nodes to extract weights for, with names to give the extracted
weights. The user can then call this util with a set
of nodes and names created in any way they want.

Test Plan:

python test/test_quantization.py TestFXNumericSuiteCoreAPIs

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D26487270

@vkuzo
ns for fx: make unshadowed activation comparison work for N models
bf279c1 
Summary:

Refactor the NS for FX compare unshadowed activations API to be able
to work on N models and do arbitrary matching strategies.

We factor out a util which takes a model and a list of
nodes to extract weights for, with names to give the extracted
weights. The user can then call this util with a set
of nodes and names created in any way they want.

Test Plan:

```
python test/test_quantization.py TestFXNumericSuiteCoreAPIs
```

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
This was referenced Feb 17, 2021
Closed
Closed
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 17, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 5acef05 (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@vkuzo
Update on "ns for fx: make unshadowed activation comparison work for …
bfa0605 
…N models"

Summary:

Refactor the NS for FX compare unshadowed activations API to be able
to work on N models and do arbitrary matching strategies.

We factor out a util which takes a model and a list of
nodes to extract weights for, with names to give the extracted
weights. The user can then call this util with a set
of nodes and names created in any way they want.

Test Plan:

```
python test/test_quantization.py TestFXNumericSuiteCoreAPIs
```

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@vkuzo
rebase on "ns for fx: make unshadowed activation comparison work for …
a827a76 
…N models"

Summary:

Refactor the NS for FX compare unshadowed activations API to be able
to work on N models and do arbitrary matching strategies.

We factor out a util which takes a model and a list of
nodes to extract weights for, with names to give the extracted
weights. The user can then call this util with a set
of nodes and names created in any way they want.

Test Plan:

```
python test/test_quantization.py TestFXNumericSuiteCoreAPIs
```

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D26487270](https://our.internmc.facebook.com/intern/diff/D26487270)

[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Feb 17, 2021
@vkuzo
ns for fx: make unshadowed activation comparison work for N models
796ab6d 
Summary:

Refactor the NS for FX compare unshadowed activations API to be able
to work on N models and do arbitrary matching strategies.

We factor out a util which takes a model and a list of
nodes to extract weights for, with names to give the extracted
weights. The user can then call this util with a set
of nodes and names created in any way they want.

Test Plan:

```
python test/test_quantization.py TestFXNumericSuiteCoreAPIs
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: de1997e
Pull Request resolved: #52357
@vkuzo vkuzo mentioned this pull request Feb 17, 2021
Closed
This was referenced Feb 17, 2021
Closed
Closed
vkuzo added 2 commits February 17, 2021 16:25
@vkuzo
rebase on "ns for fx: make unshadowed activation comparison work for …
56d96b3 
…N models"

Summary:

Refactor the NS for FX compare unshadowed activations API to be able
to work on N models and do arbitrary matching strategies.

We factor out a util which takes a model and a list of
nodes to extract weights for, with names to give the extracted
weights. The user can then call this util with a set
of nodes and names created in any way they want.

Test Plan:

```
python test/test_quantization.py TestFXNumericSuiteCoreAPIs
```

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D26487270](https://our.internmc.facebook.com/intern/diff/D26487270)

[ghstack-poisoned]
@vkuzo
fix asan on "ns for fx: make unshadowed activation comparison work fo…
5acef05 
…r N models"

Summary:

Refactor the NS for FX compare unshadowed activations API to be able
to work on N models and do arbitrary matching strategies.

We factor out a util which takes a model and a list of
nodes to extract weights for, with names to give the extracted
weights. The user can then call this util with a set
of nodes and names created in any way they want.

Test Plan:

```
python test/test_quantization.py TestFXNumericSuiteCoreAPIs
```

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D26487270](https://our.internmc.facebook.com/intern/diff/D26487270)

[ghstack-poisoned]
@codecov
Copy link

codecov bot commented Feb 18, 2021 •
edited
Loading

Codecov Report

Merging #52357 (5acef05) into gh/vkuzo/228/base (6eb16e3) will decrease coverage by 0.00%.
The diff coverage is 96.77%.

@@                  Coverage Diff                  @@
##           gh/vkuzo/228/base   #52357      +/-   ##
=====================================================
- Coverage              80.34%   80.34%   -0.01%     
=====================================================
  Files                   1967     1967              
  Lines                 215728   215737       +9     
=====================================================
+ Hits                  173321   173328       +7     
- Misses                 42407    42409       +2

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in ad97464.

@facebook-github-bot facebook-github-bot deleted the gh/vkuzo/228/head branch February 22, 2021 15:17
xsacha pushed a commit to xsacha/pytorch that referenced this pull request Mar 31, 2021
@vkuzo
ns for fx: make unshadowed activation comparison work for N models (p…
9e57010 
…ytorch#52357)

Summary:
Pull Request resolved: pytorch#52357

Refactor the NS for FX compare unshadowed activations API to be able
to work on N models and do arbitrary matching strategies.

We factor out a util which takes a model and a list of
nodes to extract weights for, with names to give the extracted
weights. The user can then call this util with a set
of nodes and names created in any way they want.

Test Plan:
```
python test/test_quantization.py TestFXNumericSuiteCoreAPIs
```

Imported from OSS

Reviewed By: raghuramank100

Differential Revision: D26487270

fbshipit-source-id: 1372ef07b5f3ddc7cebdfb2dee0221a2facd0527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@raghuramank100 raghuramank100 raghuramank100 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vkuzo @facebook-github-bot @raghuramank100