-
Notifications
You must be signed in to change notification settings - Fork 25k
Added torch.linalg.matrix_power #52608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added torch.linalg.matrix_power #52608
Conversation
[ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 8a24747 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
…rix_power" **TODO** - [x] Add OpInfo - [x] Update documentation - [ ] Add more tests and compare against NumPy - [ ] Benchmark against NumPy [ghstack-poisoned]
…rix_power" **TODO** - [x] Add OpInfo - [x] Update documentation - [x] Add more tests and compare against NumPy - [ ] Benchmark against NumPy [ghstack-poisoned]
**TODO** - [x] Add OpInfo - [x] Update documentation - [x] Add more tests and compare against NumPy - [ ] Benchmark against NumPy [ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me except for the out= behavior, which would be nice to address (and maybe providing the helper function for safe copying we've discussed before).
The ideep/tensorpipe changes should be reverted and the PR rebased past the mypy failures in its base.
The plan is for a follow-up PR to alias torch.matrix_power to torch.linalg.matrix_power, right?
@IvanYashchuk would you like to take a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@heitorschueroff could you also post the runtime for the OpInfo checks? (--durations=0
option for pytest)
**TODO** - [x] Add OpInfo - [x] Update documentation - [x] Add more tests and compare against NumPy - [ ] Benchmark against NumPy [ghstack-poisoned]
**TODO** - [x] Add OpInfo - [x] Update documentation - [x] Add more tests and compare against NumPy - [ ] Benchmark against NumPy [ghstack-poisoned]
**TODO** - [x] Add OpInfo - [x] Update documentation - [x] Add more tests and compare against NumPy - [ ] Benchmark against NumPy [ghstack-poisoned]
**TODO** - [x] Add OpInfo - [x] Update documentation - [x] Add more tests and compare against NumPy - [ ] Benchmark against NumPy [ghstack-poisoned]
|
**TODO** - [x] Add OpInfo - [x] Update documentation - [x] Add more tests and compare against NumPy - [ ] Benchmark against NumPy [ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @heitorschueroff!
I think the test failures are erroneous. You may want to rebase to verify the docs build failure isn't related to this PR.
**TODO** - [x] Add OpInfo - [x] Update documentation - [x] Add more tests and compare against NumPy - [ ] Benchmark against NumPy [ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This accidentally picked up some fbgemm and tensorpipe changes that should be reverted.
**TODO** - [x] Add OpInfo - [x] Update documentation - [x] Add more tests and compare against NumPy [ghstack-poisoned]
**TODO** - [x] Add OpInfo - [x] Update documentation - [x] Add more tests and compare against NumPy [ghstack-poisoned]
**TODO** - [x] Add OpInfo - [x] Update documentation - [x] Add more tests and compare against NumPy [ghstack-poisoned]
**TODO** - [x] Add OpInfo - [x] Update documentation - [x] Add more tests and compare against NumPy Differential Revision: [D27260630](https://our.internmc.facebook.com/intern/diff/D27260630) [ghstack-poisoned]
@heitorschueroff merged this pull request in f9e7f13. |
Stack from ghstack:
TODO
Differential Revision: D27261532