Boxing logic forwards arguments to stack #53624
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the boxing logic didn't correctly forward arguments to the stack but called copy constructors. This PR fixes that. Differential Revision: [D26852856](https://our.internmc.facebook.com/intern/diff/D26852856/) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 2f7d2a0 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Mar 9, 2021
Closed
smessmer
added a commit
that referenced
this pull request
Mar 9, 2021
Previously, the boxing logic didn't correctly forward arguments to the stack but called copy constructors. This PR fixes that. Differential Revision: [D26852856](https://our.internmc.facebook.com/intern/diff/D26852856/) ghstack-source-id: 123445819 Pull Request resolved: #53624
Previously, the boxing logic didn't correctly forward arguments to the stack but called copy constructors. This PR fixes that. Differential Revision: [D26852856](https://our.internmc.facebook.com/intern/diff/D26852856/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Mar 9, 2021
Pull Request resolved: #53624 Previously, the boxing logic didn't correctly forward arguments to the stack but called copy constructors. This PR fixes that. ghstack-source-id: 123460685 Differential Revision: [D26852856](https://our.internmc.facebook.com/intern/diff/D26852856/)
Previously, the boxing logic didn't correctly forward arguments to the stack but called copy constructors. This PR fixes that. Differential Revision: [D26852856](https://our.internmc.facebook.com/intern/diff/D26852856/) [ghstack-poisoned]
Previously, the boxing logic didn't correctly forward arguments to the stack but called copy constructors. This PR fixes that. Differential Revision: [D26852856](https://our.internmc.facebook.com/intern/diff/D26852856/) [ghstack-poisoned]
ezyang
approved these changes
Mar 10, 2021
bhosmer
approved these changes
Mar 10, 2021
Previously, the boxing logic didn't correctly forward arguments to the stack but called copy constructors. This PR fixes that. Differential Revision: [D26852856](https://our.internmc.facebook.com/intern/diff/D26852856/) [ghstack-poisoned]
Previously, the boxing logic didn't correctly forward arguments to the stack but called copy constructors. This PR fixes that. Differential Revision: [D26852856](https://our.internmc.facebook.com/intern/diff/D26852856/) [ghstack-poisoned]
Previously, the boxing logic didn't correctly forward arguments to the stack but called copy constructors. This PR fixes that. Differential Revision: [D26852856](https://our.internmc.facebook.com/intern/diff/D26852856/) [ghstack-poisoned]
Previously, the boxing logic didn't correctly forward arguments to the stack but called copy constructors. This PR fixes that. Differential Revision: [D26852856](https://our.internmc.facebook.com/intern/diff/D26852856/) [ghstack-poisoned]
Previously, the boxing logic didn't correctly forward arguments to the stack but called copy constructors. This PR fixes that. Differential Revision: [D26852856](https://our.internmc.facebook.com/intern/diff/D26852856/) [ghstack-poisoned]
Previously, the boxing logic didn't correctly forward arguments to the stack but called copy constructors. This PR fixes that. Differential Revision: [D26852856](https://our.internmc.facebook.com/intern/diff/D26852856/) [ghstack-poisoned]
Previously, the boxing logic didn't correctly forward arguments to the stack but called copy constructors. This PR fixes that. Differential Revision: [D26852856](https://our.internmc.facebook.com/intern/diff/D26852856/) [ghstack-poisoned]
Previously, the boxing logic didn't correctly forward arguments to the stack but called copy constructors. This PR fixes that. Differential Revision: [D26852856](https://our.internmc.facebook.com/intern/diff/D26852856/) [ghstack-poisoned]
Previously, the boxing logic didn't correctly forward arguments to the stack but called copy constructors. This PR fixes that. Differential Revision: [D26852856](https://our.internmc.facebook.com/intern/diff/D26852856/) [ghstack-poisoned]
Previously, the boxing logic didn't correctly forward arguments to the stack but called copy constructors. This PR fixes that. Differential Revision: [D26852856](https://our.internmc.facebook.com/intern/diff/D26852856/) [ghstack-poisoned]
Previously, the boxing logic didn't correctly forward arguments to the stack but called copy constructors. This PR fixes that. Differential Revision: [D26852856](https://our.internmc.facebook.com/intern/diff/D26852856/) [ghstack-poisoned]
Previously, the boxing logic didn't correctly forward arguments to the stack but called copy constructors. This PR fixes that. Differential Revision: [D26852856](https://our.internmc.facebook.com/intern/diff/D26852856/) [ghstack-poisoned]
Previously, the boxing logic didn't correctly forward arguments to the stack but called copy constructors. This PR fixes that. Differential Revision: [D26852856](https://our.internmc.facebook.com/intern/diff/D26852856/) [ghstack-poisoned]
Previously, the boxing logic didn't correctly forward arguments to the stack but called copy constructors. This PR fixes that. Differential Revision: [D26852856](https://our.internmc.facebook.com/intern/diff/D26852856/) [ghstack-poisoned]
Previously, the boxing logic didn't correctly forward arguments to the stack but called copy constructors. This PR fixes that. Differential Revision: [D26852856](https://our.internmc.facebook.com/intern/diff/D26852856/) [ghstack-poisoned]
|
This pull request has been merged in acfb05f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Previously, the boxing logic didn't correctly forward arguments to the stack but called copy constructors.
This PR fixes that.
Differential Revision: D26852856