Add support for single tensor in inputs argument for backward
#53827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit b47ab0c (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
soulitzer
force-pushed
the
bw-nontensor-inputs
branch
from
730f9da to
3fa7523
Compare
albanD
requested changes
Mar 11, 2021
Codecov Report
@@ Coverage Diff @@
## master #53827 +/- ##
==========================================
- Coverage 77.36% 76.98% -0.38%
==========================================
Files 1882 1882
Lines 183452 183452
==========================================
- Hits 141928 141238 -690
- Misses 41524 42214 +690 |
albanD
approved these changes
Mar 12, 2021
There was a problem hiding this comment.
@soulitzer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@soulitzer merged this pull request in 7297556. |
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
…rch#53827) Summary: Also updates the doc such that the language matches the type. For example, previously the `tensors` argument is specified as `(sequence of tensor)`, but has type annotation of `_TensorOrTensors`. Now its correctly updated to be `Sequence[Tensor] or Tensor` Pull Request resolved: pytorch#53827 Reviewed By: albanD Differential Revision: D26997541 Pulled By: soulitzer fbshipit-source-id: e1e609a4e9525139d0fe96f6157175481c90d6f8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates the doc such that the language matches the type. For example, previously the
tensorsargument is specified as(sequence of tensor), but has type annotation of_TensorOrTensors. Now its correctly updated to beSequence[Tensor] or Tensor