Skip to content

Conversation

hlu1
Copy link
Contributor

@hlu1 hlu1 commented Mar 16, 2021

Summary: If we only run the ReplaceWithCopy pass when enable_out_variant is true, there is no need register a default op implementation.

Reviewed By: edvgha

Differential Revision: D27036077

…t is true

Summary: If we only run the ReplaceWithCopy pass when enable_out_variant is true, there is no need register a default op implementation.

Reviewed By: edvgha

Differential Revision: D27036077

fbshipit-source-id: eee203bd9974be5cd82e4a22241dee7d2cbada59
@facebook-github-bot facebook-github-bot added oncall: jit Add this issue/PR to JIT oncall triage queue cla signed labels Mar 16, 2021
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 16, 2021

💊 CI failures summary and remediations

As of commit fb72839 (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build clang-tidy (1/1)

Step: "Add annotations" (full log | diagnosis details | 🔁 rerun)

2021-03-16T23:40:40.7479251Z update-alternatives: error: no alternatives for nsight-sys
2021-03-16T23:40:40.6960348Z Setting up x11proto-damage-dev (1:2018.4-4) ...
2021-03-16T23:40:40.6995259Z Setting up cuda-nvjpeg-10-2 (10.2.89-1) ...
2021-03-16T23:40:40.7075449Z Setting up libxcb-dri3-dev:amd64 (1.13-2~ubuntu18.04) ...
2021-03-16T23:40:40.7115642Z Setting up libcublas10 (10.2.3.254-1) ...
2021-03-16T23:40:40.7139318Z Setting up libcublas-dev (10.2.3.254-1) ...
2021-03-16T23:40:40.7167457Z Setting up cuda-cufft-10-2 (10.2.89-1) ...
2021-03-16T23:40:40.7245320Z Setting up cuda-nsight-compute-10-2 (10.2.89-1) ...
2021-03-16T23:40:40.7279138Z Setting up nsight-systems-2020.4.3 (2020.4.3.7-10543b6) ...
2021-03-16T23:40:40.7377274Z update-alternatives: using /opt/nvidia/nsight-systems/2020.4.3/target-linux-x64/nsys to provide /usr/local/bin/nsys (nsys) in auto mode
2021-03-16T23:40:40.7467380Z update-alternatives: error: alternative path /opt/nvidia/nsight-systems/2020.4.3/host-linux-x64/nsight-sys doesn't exist
2021-03-16T23:40:40.7479251Z update-alternatives: error: no alternatives for nsight-sys
2021-03-16T23:40:40.7542902Z update-alternatives: using /opt/nvidia/nsight-systems/2020.4.3/host-linux-x64/nsys-ui to provide /usr/local/bin/nsys-ui (nsys-ui) in auto mode
2021-03-16T23:40:40.7600027Z Setting up libxcb-shape0-dev:amd64 (1.13-2~ubuntu18.04) ...
2021-03-16T23:40:40.7633458Z Setting up cuda-cusparse-10-2 (10.2.89-1) ...
2021-03-16T23:40:40.7709649Z Setting up cuda-cuobjdump-10-2 (10.2.89-1) ...
2021-03-16T23:40:40.7744519Z Setting up libxcb-glx0-dev:amd64 (1.13-2~ubuntu18.04) ...
2021-03-16T23:40:40.7781693Z Setting up libgles2:amd64 (1.0.0-2ubuntu2.3) ...
2021-03-16T23:40:40.7809377Z Setting up libglu1-mesa:amd64 (9.0.0-2.1build1) ...
2021-03-16T23:40:40.7831423Z Setting up libegl-mesa0:amd64 (20.0.8-0ubuntu1~18.04.1) ...
2021-03-16T23:40:40.7908808Z Setting up cuda-sanitizer-api-10-2 (10.2.89-1) ...
2021-03-16T23:40:40.7979924Z Setting up cuda-nvjpeg-dev-10-2 (10.2.89-1) ...

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D27036077

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #54111 (fb72839) into master (dc07060) will increase coverage by 0.00%.
The diff coverage is 20.00%.

@@           Coverage Diff           @@
##           master   #54111   +/-   ##
=======================================
  Coverage   77.33%   77.33%           
=======================================
  Files        1888     1888           
  Lines      185053   185034   -19     
=======================================
- Hits       143108   143104    -4     
+ Misses      41945    41930   -15     

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 04d5278.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed fb-exported Merged oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants