-
Notifications
You must be signed in to change notification settings - Fork 25.5k
Deprecate legacy constructor torch.Tensor()
#54414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CI failures summary and remediationsAs of commit 4e49486 (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
@heitorschueroff merged this pull request in 4e5af53. |
This reverts commit 4e5af53.
Reverting this change because of the warnings when people subclass Tensor. @ysiraichi apologies for not catching this problem before, we should continue discussion of how to correctly deprecate this in the issue you opened #55780 |
This reverts commit 4e5af53.
pytorch#55831) Summary: This PR reverts pytorch#54414 because of pytorch#55780 cc ysiraichi Pull Request resolved: pytorch#55831 Reviewed By: agolynski Differential Revision: D27762264 Pulled By: heitorschueroff fbshipit-source-id: 8079a660cc440cafb9d22aa031d36dde121e13b3
Fixes #47112
This pull request is the final step in the proposed plan for deprecating
torch.Tensor()
constructor. Specifically, it updates the docs and throwsTORCH_WARN_ONCE
if someone usestorch.Tensor()
.