Skip to content

Conversation

ysiraichi
Copy link
Collaborator

Fixes #47112

This pull request is the final step in the proposed plan for deprecating torch.Tensor() constructor. Specifically, it updates the docs and throws TORCH_WARN_ONCE if someone uses torch.Tensor().

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 22, 2021

💊 CI failures summary and remediations

As of commit 4e49486 (more details on the Dr. CI page):



🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_build (1/2)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.
CONFLICT (add/add): Merge conflict in .circleci/regenerate.sh
Auto-merging .circleci/regenerate.sh
CONFLICT (add/add): Merge conflict in .circleci/docker/common/install_conda.sh
Auto-merging .circleci/docker/common/install_conda.sh
CONFLICT (add/add): Merge conflict in .circleci/docker/build.sh
Auto-merging .circleci/docker/build.sh
CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/simple/docker_definitions.py
Auto-merging .circleci/cimodel/data/simple/docker_definitions.py
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_build (2/2)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.
CONFLICT (add/add): Merge conflict in .circleci/regenerate.sh
Auto-merging .circleci/regenerate.sh
CONFLICT (add/add): Merge conflict in .circleci/docker/common/install_conda.sh
Auto-merging .circleci/docker/common/install_conda.sh
CONFLICT (add/add): Merge conflict in .circleci/docker/build.sh
Auto-merging .circleci/docker/build.sh
CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/simple/docker_definitions.py
Auto-merging .circleci/cimodel/data/simple/docker_definitions.py
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1


🚧 3 fixed upstream failures:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@ysiraichi
Copy link
Collaborator Author

Here's a screenshot of a relevant part of the generated documentation (at tensors.html):

2021-03-22-221246_859x433_scrot

@heitorschueroff heitorschueroff self-requested a review March 22, 2021 21:23
@heitorschueroff heitorschueroff added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Mar 22, 2021
@facebook-github-bot
Copy link
Contributor

@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@heitorschueroff merged this pull request in 4e5af53.

@heitorschueroff
Copy link
Contributor

heitorschueroff commented Apr 12, 2021

Reverting this change because of the warnings when people subclass Tensor. @ysiraichi apologies for not catching this problem before, we should continue discussion of how to correctly deprecate this in the issue you opened #55780

heitorschueroff added a commit that referenced this pull request Apr 13, 2021
facebook-github-bot pushed a commit that referenced this pull request Apr 15, 2021
Summary:
This PR reverts #54414 because of #55780

cc ysiraichi

Pull Request resolved: #55831

Reviewed By: agolynski

Differential Revision: D27762264

Pulled By: heitorschueroff

fbshipit-source-id: 8079a660cc440cafb9d22aa031d36dde121e13b3
krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request May 19, 2021
pytorch#55831)

Summary:
This PR reverts pytorch#54414 because of pytorch#55780

cc ysiraichi

Pull Request resolved: pytorch#55831

Reviewed By: agolynski

Differential Revision: D27762264

Pulled By: heitorschueroff

fbshipit-source-id: 8079a660cc440cafb9d22aa031d36dde121e13b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Legacy tensor ctor returns uninitialized tensor when input and output device differ

4 participants