-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[JIT] fix freezing with mkldnn tensors #54632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CI failures summary and remediationsAs of commit 4413968 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…le_freezing_mkldnn
@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Codecov Report
@@ Coverage Diff @@
## master #54632 +/- ##
=======================================
Coverage 77.41% 77.41%
=======================================
Files 1893 1893
Lines 186226 186231 +5
=======================================
+ Hits 144159 144169 +10
+ Misses 42067 42062 -5 |
Saving a frozen MKL is still not working for me in latest nightly. |
@xsacha i dont think saving and loading mkldnn tensors work on JIT without freezing, this was just fixing a freezing error. but agreed that it would be nice to fix that. Do you mind opening an issue ? |
I can save a JIT mkldnn model without freezing, but when performing the freeze beforehand and then trying to save I get that error. |
We were accessing their storage which will throw