Skip to content

Conversation

eellison
Copy link
Contributor

We were accessing their storage which will throw

@eellison eellison requested a review from Krovatkin March 24, 2021 22:27
@facebook-github-bot facebook-github-bot added oncall: jit Add this issue/PR to JIT oncall triage queue cla signed labels Mar 24, 2021
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 24, 2021

💊 CI failures summary and remediations

As of commit 4413968 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-scanned failure(s)

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Copy link
Contributor

@Krovatkin Krovatkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@facebook-github-bot
Copy link
Contributor

@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Mar 27, 2021

Codecov Report

Merging #54632 (4413968) into master (ee73c75) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #54632   +/-   ##
=======================================
  Coverage   77.41%   77.41%           
=======================================
  Files        1893     1893           
  Lines      186226   186231    +5     
=======================================
+ Hits       144159   144169   +10     
+ Misses      42067    42062    -5     

@facebook-github-bot
Copy link
Contributor

@eellison merged this pull request in 63997db.

@xsacha
Copy link
Contributor

xsacha commented Apr 12, 2021

Saving a frozen MKL is still not working for me in latest nightly.
I get a different error now:
NotImplementedError: Cannot access storage of OpaqueTensorImpl

@eellison
Copy link
Contributor Author

@xsacha i dont think saving and loading mkldnn tensors work on JIT without freezing, this was just fixing a freezing error. but agreed that it would be nice to fix that. Do you mind opening an issue ?

@xsacha
Copy link
Contributor

xsacha commented Apr 12, 2021

I can save a JIT mkldnn model without freezing, but when performing the freeze beforehand and then trying to save I get that error.
Prior to this commit I couldn't do the freeze.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants