[DDP] Mark a few variables as const in reducer #54764
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We mark a few vars as const in Reducer, also do this for replicas_ and process_group_ as they should not be changed by Reducer during training. This can help eliminate issues at compile time and prevent the developer from accidently changing these variables. Differential Revision: [D27357132](https://our.internmc.facebook.com/intern/diff/D27357132/) [ghstack-poisoned]
rohan-varma
requested review from
H-Huang,
mingzhe09088,
mrshenli,
pritamdamania87,
wayi1 and
zhaojuanmao
as code owners
💊 CI failures summary and remediationsAs of commit 143c79b (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
oncall: distributed
rohan-varma
added a commit
that referenced
this pull request
Mar 26, 2021
We mark a few vars as const in Reducer, also do this for replicas_ and process_group_ as they should not be changed by Reducer during training. This can help eliminate issues at compile time and prevent the developer from accidently changing these variables. Differential Revision: [D27357132](https://our.internmc.facebook.com/intern/diff/D27357132/) ghstack-source-id: 124983037 Pull Request resolved: #54764
wayi1
approved these changes
Mar 26, 2021
We mark a few vars as const in Reducer, also do this for replicas_ and process_group_ as they should not be changed by Reducer during training. Differential Revision: [D27357132](https://our.internmc.facebook.com/intern/diff/D27357132/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Mar 26, 2021
Pull Request resolved: #54764 We mark a few vars as const in Reducer, also do this for replicas_ and process_group_ as they should not be changed by Reducer during training. This can help eliminate issues at compile time and prevent the developer from accidently changing these variables. ghstack-source-id: 125040110 Differential Revision: [D27357132](https://our.internmc.facebook.com/intern/diff/D27357132/)
|
This pull request has been merged in 5c3d80d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
We mark a few vars as const in Reducer, also do this for replicas_ and
process_group_ as they should not be changed by Reducer during training.
Differential Revision: D27357132