[ROCm] if TEST_WITH_ROCM, only instantiate GPU device tests #55069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 8a4c5e7 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Not sure why we're seeing such variation. |
Codecov Report
@@ Coverage Diff @@
## master #55069 +/- ##
===========================================
+ Coverage 60.24% 77.28% +17.03%
===========================================
Files 564 1893 +1329
Lines 69908 186474 +116566
===========================================
+ Hits 42118 144118 +102000
- Misses 27790 42356 +14566 |
I took a look at the logs for test2; it seems that the unit test suites in the 2 logs are not exactly the same. |
malfet
approved these changes
Apr 7, 2021
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
pytorchmergebot
pushed a commit
that referenced
this pull request
May 3, 2022
This env var works similarly for both cuda and rocm builds. Consider removing the ROCm-specific change in #55069 which came before the addition of this env var for cuda. Pull Request resolved: #76668 Approved by: https://github.com/janeyx99
facebook-github-bot
pushed a commit
that referenced
this pull request
May 4, 2022
Summary: This env var works similarly for both cuda and rocm builds. Consider removing the ROCm-specific change in #55069 which came before the addition of this env var for cuda. Pull Request resolved: #76668 Approved by: https://github.com/janeyx99 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f1f29ac8b3cc3d7454a2d62cf0de525fe59eeeac Reviewed By: malfet Differential Revision: D36134095 fbshipit-source-id: 8a4a8473fbb1bc26caabcede3f2540e9d699a67b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves ROCm CI throughput by instantiating only for device tests that exercise the AMD GPU devices.