Implement torch.reshape and Tensor.reshape by colesbury · Pull Request #5575 · pytorch/pytorch

colesbury · 2018-03-05T20:28:57Z

This implements reshape which has similar semantics to numpy.reshape. It
will return a view of the source tensor if possible. Otherwise, it
returns a copy.

This implements reshape which has similar semantics to numpy.reshape. It will return a view of the source tensor if possible. Otherwise, it returns a copy.

aten/src/ATen/native/TensorShape.cpp

  return result;
 }

+static std::vector<int64_t> infer_size(IntList shape, int64_t numel) {


aten/src/ATen/native/TensorShape.cpp

+static std::vector<int64_t> infer_size(IntList shape, int64_t numel) {
+  auto res = shape.vec();
+  int64_t newsize = 1;
+  auto infer_dim = at::optional<int64_t>();


aten/src/ATen/native/TensorShape.cpp

+        view_d--;
+      }
+      if (view_numel != tensor_numel) {
+        return {};


Implement torch.reshape and Tensor.reshape

b3b7d10

This implements reshape which has similar semantics to numpy.reshape. It will return a view of the source tensor if possible. Otherwise, it returns a copy.

colesbury requested a review from gchanan March 5, 2018 20:28

Remove in-place reshape_ that was an alias for resize_

86cb6e2

onnxbot-worker-2 mentioned this pull request Mar 5, 2018

[auto] pytorch-pr-5575 onnxbot/onnx-fb-universe#954

Closed

ezyang reviewed Mar 7, 2018

View reviewed changes

aten/src/ATen/native/TensorShape.cpp

return result;

}

static std::vector<int64_t> infer_size(IntList shape, int64_t numel) {

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

ezyang reviewed Mar 7, 2018

View reviewed changes

aten/src/ATen/native/TensorShape.cpp

static std::vector<int64_t> infer_size(IntList shape, int64_t numel) {

auto res = shape.vec();

int64_t newsize = 1;

auto infer_dim = at::optional<int64_t>();

This comment was marked as off-topic.

Sign in to view

ezyang reviewed Mar 7, 2018

View reviewed changes

colesbury added 2 commits March 12, 2018 12:31

Update documentation

f283e61

Merge branch 'master' into reshape

1eb9171

soumith merged commit a264150 into pytorch:master Mar 12, 2018

colesbury deleted the reshape branch March 12, 2018 21:24

fmassa mentioned this pull request Mar 23, 2018

Group Normalization #5968

Merged

Conversation

colesbury commented Mar 5, 2018

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

This comment was marked as off-topic.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants