Skip to content

Implement torch.reshape and Tensor.reshape #5575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 12, 2018
Merged

Implement torch.reshape and Tensor.reshape #5575

merged 4 commits into from
Mar 12, 2018

Conversation

colesbury
Copy link
Member

This implements reshape which has similar semantics to numpy.reshape. It
will return a view of the source tensor if possible. Otherwise, it
returns a copy.

@colesbury
Implement torch.reshape and Tensor.reshape
b3b7d10 
This implements reshape which has similar semantics to numpy.reshape. It
will return a view of the source tensor if possible. Otherwise, it
returns a copy.
@colesbury colesbury requested a review from gchanan March 5, 2018 20:28
@onnxbot-worker-2 onnxbot-worker-2 mentioned this pull request Mar 5, 2018
Closed
ezyang
ezyang reviewed Mar 7, 2018
View reviewed changes
aten/src/ATen/native/TensorShape.cpp
return result;
}

static std::vector<int64_t> infer_size(IntList shape, int64_t numel) {

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

ezyang
ezyang reviewed Mar 7, 2018
View reviewed changes
aten/src/ATen/native/TensorShape.cpp
static std::vector<int64_t> infer_size(IntList shape, int64_t numel) {
auto res = shape.vec();
int64_t newsize = 1;
auto infer_dim = at::optional<int64_t>();

This comment was marked as off-topic.

Sign in to view

ezyang
ezyang reviewed Mar 7, 2018
View reviewed changes
aten/src/ATen/native/TensorShape.cpp
view_d--;
}
if (view_numel != tensor_numel) {
return {};

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@soumith soumith merged commit a264150 into pytorch:master Mar 12, 2018
@colesbury colesbury deleted the reshape branch March 12, 2018 21:24
@fmassa fmassa mentioned this pull request Mar 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang left review comments

@gchanan gchanan Awaiting requested review from gchanan

+1 more reviewer

@apaszke apaszke apaszke left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@colesbury @ezyang @apaszke @soumith