[TensorExpr] Fuser: don't lift tensor constants from fusion groups. #56756
+0
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With #56319 TE kernel could handle tensor constants, so there is no more need in lifting them out and passing as inputs. [ghstack-poisoned]
facebook-github-bot
added
oncall: jit
💊 CI failures summary and remediationsAs of commit 0d02b13 (more details on the Dr. CI page):
6 failures not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
ZolotukhinM
requested review from
eellison,
bertmaher and
Krovatkin
and removed request for
eellison and
bertmaher
…n groups." With #56319 TE kernel could handle tensor constants, so there is no more need in lifting them out and passing as inputs. [ghstack-poisoned]
…n groups." With #56319 TE kernel could handle tensor constants, so there is no more need in lifting them out and passing as inputs. Differential Revision: [D27959258](https://our.internmc.facebook.com/intern/diff/D27959258) [ghstack-poisoned]
bertmaher
approved these changes
Apr 24, 2021
added 4 commits
April 24, 2021 10:58
…n groups." With #56319 TE kernel could handle tensor constants, so there is no more need in lifting them out and passing as inputs. Differential Revision: [D27959258](https://our.internmc.facebook.com/intern/diff/D27959258) [ghstack-poisoned]
…n groups." With #56319 TE kernel could handle tensor constants, so there is no more need in lifting them out and passing as inputs. Differential Revision: [D27959258](https://our.internmc.facebook.com/intern/diff/D27959258) [ghstack-poisoned]
…n groups." With #56319 TE kernel could handle tensor constants, so there is no more need in lifting them out and passing as inputs. Differential Revision: [D27959258](https://our.internmc.facebook.com/intern/diff/D27959258) [ghstack-poisoned]
…n groups." With #56319 TE kernel could handle tensor constants, so there is no more need in lifting them out and passing as inputs. Differential Revision: [D27959258](https://our.internmc.facebook.com/intern/diff/D27959258) [ghstack-poisoned]
|
@ZolotukhinM merged this pull request in 1faf1f9. |
crcrpar
pushed a commit
to crcrpar/pytorch
that referenced
this pull request
May 7, 2021
…ytorch#56756) Summary: Pull Request resolved: pytorch#56756 With pytorch#56319 TE kernel could handle tensor constants, so there is no more need in lifting them out and passing as inputs. Test Plan: Imported from OSS Reviewed By: bertmaher Differential Revision: D27959258 Pulled By: ZolotukhinM fbshipit-source-id: 00269cf1c4747c10dfc40cb4e330991d0bf1e2ee
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
…ytorch#56756) Summary: Pull Request resolved: pytorch#56756 With pytorch#56319 TE kernel could handle tensor constants, so there is no more need in lifting them out and passing as inputs. Test Plan: Imported from OSS Reviewed By: bertmaher Differential Revision: D27959258 Pulled By: ZolotukhinM fbshipit-source-id: 00269cf1c4747c10dfc40cb4e330991d0bf1e2ee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
With #56319 TE kernel could handle tensor constants, so there is no more
need in lifting them out and passing as inputs.
Differential Revision: D27959258