-
Notifications
You must be signed in to change notification settings - Fork 25k
[ONNX] Add support for calling tensor.to(tensor.device). #56857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CI failures summary and remediationsAs of commit 0398127 (more details on the Dr. CI page):
🕵️ 4 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
Currently, if we call tensor.to() method and pass a device as the parameter. It will fail, because in symbolic function of to() we didn't handle such case. So add a check in the beginning of this symbolic function, if this is a device cast, we return self directly. A test has also been added. Co-authored-by: Jay Zhang <jiz@microsoft.com> [ghstack-poisoned]
Currently, if we call tensor.to() method and pass a device as the parameter. It will fail, because in symbolic function of to() we didn't handle such case. So add a check in the beginning of this symbolic function, if this is a device cast, we return self directly. A test has also been added. Co-authored-by: Jay Zhang <jiz@microsoft.com> [ghstack-poisoned]
Currently, if we call tensor.to() method and pass a device as the parameter. It will fail, because in symbolic function of to() we didn't handle such case. So add a check in the beginning of this symbolic function, if this is a device cast, we return self directly. A test has also been added. Co-authored-by: Jay Zhang <jiz@microsoft.com> [ghstack-poisoned]
Currently, if we call tensor.to() method and pass a device as the parameter. It will fail, because in symbolic function of to() we didn't handle such case. So add a check in the beginning of this symbolic function, if this is a device cast, we return self directly. A test has also been added. Co-authored-by: Jay Zhang <jiz@microsoft.com> [ghstack-poisoned]
Summary: Pull Request resolved: #57599 Currently, if we call tensor.to() method and pass a device as the parameter. It will fail, because in symbolic function of to() we didn't handle such case. So add a check in the beginning of this symbolic function, if this is a device cast, we return self directly. A test has also been added. Test Plan: Imported from OSS Reviewed By: malfet Differential Revision: D28393523 Pulled By: SplitInfinity fbshipit-source-id: c41e3c0293932fc90dedb544daadd9c5d4b48792 Co-authored-by: Jay Zhang <jiz@microsoft.com>
Currently, if we call tensor.to() method and pass a device as the parameter. It will fail, because in symbolic function of to() we didn't handle such case. So add a check in the beginning of this symbolic function, if this is a device cast, we return self directly. A test has also been added. Co-authored-by: Jay Zhang <jiz@microsoft.com> ghstack-source-id: e5a436f Pull Request resolved: pytorch#57599
Summary: Pull Request resolved: pytorch#57599 Currently, if we call tensor.to() method and pass a device as the parameter. It will fail, because in symbolic function of to() we didn't handle such case. So add a check in the beginning of this symbolic function, if this is a device cast, we return self directly. A test has also been added. Test Plan: Imported from OSS Reviewed By: malfet Differential Revision: D28393523 Pulled By: SplitInfinity fbshipit-source-id: c41e3c0293932fc90dedb544daadd9c5d4b48792 Co-authored-by: Jay Zhang <jiz@microsoft.com>
Currently, if we call tensor.to() method and pass a device as the parameter. It will fail, because in symbolic function of to() we didn't handle such case.
So add a check in the beginning of this symbolic function, if this is a device cast, we return self directly. A test has also been added.