Skip to content

Added doc for torch.einsum sublist format #57038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from

Conversation

heitorschueroff
Copy link
Contributor

@heitorschueroff heitorschueroff commented Apr 27, 2021

Adds documentation for the new sublist format for torch.einsum

closes #21412

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 27, 2021

💊 CI failures summary and remediations

As of commit 6f93b4b (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_bionic_py3_6_clang9_noarch_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jun 09 17:15:29 [E request_callback_no_python.c...quest type 275: Unexpected end of pickler archive.
Jun 09 17:15:29 frame #6: torch::distributed::autograd::CleanupAutogradContextReq::fromMessage(torch::distributed::rpc::Message const&) + 0x9e (0x7f9bf00ffc5e in /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch_cpu.so)
Jun 09 17:15:29 frame #7: torch::distributed::rpc::deserializeRequest(torch::distributed::rpc::Message const&) + 0x5a (0x7f9bf01447ea in /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch_cpu.so)
Jun 09 17:15:29 frame #8: torch::distributed::rpc::RequestCallbackNoPython::processMessage(torch::distributed::rpc::Message&, std::vector<c10::Stream, std::allocator<c10::Stream> >) const + 0x4c (0x7f9bf010d3ec in /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch_cpu.so)
Jun 09 17:15:29 frame #9: torch::distributed::rpc::RequestCallback::operator()(torch::distributed::rpc::Message&, std::vector<c10::Stream, std::allocator<c10::Stream> >) const + 0x2f (0x7f9bf010d31f in /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch_cpu.so)
Jun 09 17:15:29 frame #10: <unknown function> + 0x1350539 (0x7f9bf9445539 in /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch_python.so)
Jun 09 17:15:29 frame #11: c10::ThreadPool::main_loop(unsigned long) + 0x17a (0x7f9beb919f4a in /opt/conda/lib/python3.6/site-packages/torch/lib/libc10.so)
Jun 09 17:15:29 frame #12: <unknown function> + 0xc819d (0x7f9beb82f19d in /opt/conda/lib/libstdc++.so.6)
Jun 09 17:15:29 frame #13: <unknown function> + 0x76db (0x7f9c095646db in /lib/x86_64-linux-gnu/libpthread.so.0)
Jun 09 17:15:29 frame #14: clone + 0x3f (0x7f9c0928d71f in /lib/x86_64-linux-gnu/libc.so.6)
Jun 09 17:15:29 
Jun 09 17:15:29 [E request_callback_no_python.cpp:552] Received error while processing request type 275: Unexpected end of pickler archive.
Jun 09 17:15:29 Exception raised from readSlowWithBuffer at /var/lib/jenkins/workspace/torch/csrc/jit/serialization/unpickler.cpp:756 (most recent call first):
Jun 09 17:15:29 frame #0: c10::Error::Error(c10::SourceLocation, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) + 0x7d (0x7f9beb92519d in /opt/conda/lib/python3.6/site-packages/torch/lib/libc10.so)
Jun 09 17:15:29 frame #1: c10::detail::torchCheckFail(char const*, char const*, unsigned int, char const*) + 0xdd (0x7f9beb9239dd in /opt/conda/lib/python3.6/site-packages/torch/lib/libc10.so)
Jun 09 17:15:29 frame #2: <unknown function> + 0x42f297a (0x7f9befe4b97a in /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch_cpu.so)
Jun 09 17:15:29 frame #3: torch::jit::Unpickler::run() + 0x86 (0x7f9befe43686 in /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch_cpu.so)
Jun 09 17:15:29 frame #4: torch::jit::Unpickler::parse_ivalue() + 0x19 (0x7f9befe433e9 in /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch_cpu.so)
Jun 09 17:15:29 frame #5: torch::jit::unpickle(char const*, unsigned long, std::function<c10::StrongTypePtr (c10::QualifiedName const&)>, c10::ArrayRef<at::Tensor>) + 0x1ce (0x7f9befe1bf2e in /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch_cpu.so)
Jun 09 17:15:29 frame #6: torch::distributed::autograd::CleanupAutogradContextReq::fromMessage(torch::distributed::rpc::Message const&) + 0x9e (0x7f9bf00ffc5e in /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch_cpu.so)
Jun 09 17:15:29 frame #7: torch::distributed::rpc::deserializeRequest(torch::distributed::rpc::Message const&) + 0x5a (0x7f9bf01447ea in /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch_cpu.so)
Jun 09 17:15:29 frame #8: torch::distributed::rpc::RequestCallbackNoPython::processMessage(torch::distributed::rpc::Message&, std::vector<c10::Stream, std::allocator<c10::Stream> >) const + 0x4c (0x7f9bf010d3ec in /opt/conda/lib/python3.6/site-packages/torch/lib/libtorch_cpu.so)

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@heitorschueroff heitorschueroff force-pushed the heitorschueroff/einsum-sublist-doc branch from 9c1b488 to b4db1b4 Compare April 28, 2021 17:06
@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #57038 (b4db1b4) into heitorschueroff/einsum-sublist (4d17b73) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head b4db1b4 differs from pull request most recent head 6c72a0b. Consider uploading reports for the commit 6c72a0b to get more accurate results

@@                       Coverage Diff                       @@
##           heitorschueroff/einsum-sublist   #57038   +/-   ##
===============================================================
  Coverage                           77.58%   77.58%           
===============================================================
  Files                                1949     1949           
  Lines                              194129   194129           
===============================================================
+ Hits                               150611   150616    +5     
+ Misses                              43518    43513    -5     

@heitorschueroff heitorschueroff force-pushed the heitorschueroff/einsum-sublist branch from 6fa8fc0 to 60f1487 Compare May 20, 2021 20:50
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement

@heitorschueroff heitorschueroff changed the base branch from heitorschueroff/einsum-sublist to master June 9, 2021 15:11
@facebook-github-bot
Copy link
Contributor

@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@heitorschueroff merged this pull request in 5841274.

@heitorschueroff heitorschueroff deleted the heitorschueroff/einsum-sublist-doc branch July 14, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support sublist arguments for torch.einsum
3 participants