Make CUDAFuture handle any kind of device type #57051
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make CUDAFuture autodetect the devicetype from its arguments (which thus change from DeviceIndices to full Devices). This in fact transforms CUDAFuture into a AnythingFuture, since it's not tied to CUDA in any way anymore. Having made it fully device-agnostic, we'll merge it into ivalue::Future in the next PR. Differential Revision: [D28032711](https://our.internmc.facebook.com/intern/diff/D28032711/) [ghstack-poisoned]
lw
requested review from
H-Huang,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma,
wayi1 and
zhaojuanmao
as code owners
facebook-github-bot
added
oncall: jit
💊 CI failures summary and remediationsAs of commit c147fa5 (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Apr 27, 2021
Make CUDAFuture autodetect the devicetype from its arguments (which thus change from DeviceIndices to full Devices). This in fact transforms CUDAFuture into a AnythingFuture, since it's not tied to CUDA in any way anymore. Having made it fully device-agnostic, we'll merge it into ivalue::Future in the next PR. Differential Revision: [D28032711](https://our.internmc.facebook.com/intern/diff/D28032711/) [ghstack-poisoned]
Make CUDAFuture autodetect the devicetype from its arguments (which thus change from DeviceIndices to full Devices). This in fact transforms CUDAFuture into a AnythingFuture, since it's not tied to CUDA in any way anymore. Having made it fully device-agnostic, we'll merge it into ivalue::Future in the next PR. Differential Revision: [D28032711](https://our.internmc.facebook.com/intern/diff/D28032711/) [ghstack-poisoned]
Make CUDAFuture autodetect the devicetype from its arguments (which thus change from DeviceIndices to full Devices). This in fact transforms CUDAFuture into a AnythingFuture, since it's not tied to CUDA in any way anymore. Having made it fully device-agnostic, we'll merge it into ivalue::Future in the next PR. Differential Revision: [D28032711](https://our.internmc.facebook.com/intern/diff/D28032711/) [ghstack-poisoned]
Make CUDAFuture autodetect the devicetype from its arguments (which thus change from DeviceIndices to full Devices). This in fact transforms CUDAFuture into a AnythingFuture, since it's not tied to CUDA in any way anymore. Having made it fully device-agnostic, we'll merge it into ivalue::Future in the next PR. Differential Revision: [D28032711](https://our.internmc.facebook.com/intern/diff/D28032711/) [ghstack-poisoned]
mrshenli
approved these changes
Apr 28, 2021
| @@ -34,13 +34,7 @@ def __init__(self, *, devices: Optional[List[Union[int, str, torch.device]]] = N | |||
| """ | |||
There was a problem hiding this comment.
I assume docs for devices arg will be added in follow PRs?
There was a problem hiding this comment.
I mentioned it in the paragraph but didn't add a specific section for it, let me do that.
| impl_(c10::impl::getDeviceGuardImpl(c10::kCUDA)), | ||
| devices_(sortDevices(std::move(devices))) { | ||
| impl_(getImplForDevices(devices)), | ||
| devices_(getSortedIndicesOfDevices(impl_, devices)) { |
There was a problem hiding this comment.
curious, any reason for not just storing devices instead of device indices in this change??
There was a problem hiding this comment.
At this stage I wanted to change as few things as possible to keep the delta small and thus help see that this is not changing behaviors. But, yes, I was thinking the same and I'll probably do a follow-up "polishing" PR.
Make CUDAFuture autodetect the devicetype from its arguments (which thus change from DeviceIndices to full Devices). This in fact transforms CUDAFuture into a AnythingFuture, since it's not tied to CUDA in any way anymore. Having made it fully device-agnostic, we'll merge it into ivalue::Future in the next PR. Differential Revision: [D28032711](https://our.internmc.facebook.com/intern/diff/D28032711/) [ghstack-poisoned]
Make CUDAFuture autodetect the devicetype from its arguments (which thus change from DeviceIndices to full Devices). This in fact transforms CUDAFuture into a AnythingFuture, since it's not tied to CUDA in any way anymore. Having made it fully device-agnostic, we'll merge it into ivalue::Future in the next PR. Differential Revision: [D28032711](https://our.internmc.facebook.com/intern/diff/D28032711/) [ghstack-poisoned]
Make CUDAFuture autodetect the devicetype from its arguments (which thus change from DeviceIndices to full Devices). This in fact transforms CUDAFuture into a AnythingFuture, since it's not tied to CUDA in any way anymore. Having made it fully device-agnostic, we'll merge it into ivalue::Future in the next PR. Differential Revision: [D28032711](https://our.internmc.facebook.com/intern/diff/D28032711/) [ghstack-poisoned]
|
This pull request has been merged in 71c2f88. |
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Pull Request resolved: pytorch#57051 Make CUDAFuture autodetect the devicetype from its arguments (which thus change from DeviceIndices to full Devices). This in fact transforms CUDAFuture into a AnythingFuture, since it's not tied to CUDA in any way anymore. Having made it fully device-agnostic, we'll merge it into ivalue::Future in the next PR. ghstack-source-id: 127713134 (Note: this ignores all push blocking failures!) Test Plan: CI Reviewed By: mrshenli Differential Revision: D28032711 fbshipit-source-id: 8ba23b1b0d97f61db8693cd5f3c7bae7989a9bcd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Make CUDAFuture autodetect the devicetype from its arguments (which thus change from DeviceIndices to full Devices). This in fact transforms CUDAFuture into a AnythingFuture, since it's not tied to CUDA in any way anymore. Having made it fully device-agnostic, we'll merge it into ivalue::Future in the next PR.
Differential Revision: D28032711