Make some methods of RequestCallback return void instead of bool #57849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some methods are currently returning bool, but I'll soon want them to return a Future. I could have them return a tuple of bool and Future, but that's a bit heavy. Instead it turns out we can very easily make them return void, which will simplify things. Differential Revision: [D28224476](https://our.internmc.facebook.com/intern/diff/D28224476/) [ghstack-poisoned]
lw
requested review from
H-Huang,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma,
wayi1 and
zhaojuanmao
as code owners
💊 CI failures summary and remediationsAs of commit 19bd6f0 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
 pytorch_linux_bionic_py3_6_clang9_noarch_test |
Run tests | 🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group.
facebook-github-bot
added
the
oncall: distributed
This was referenced May 7, 2021
Closed
…f bool" Some methods are currently returning bool, but I'll soon want them to return a Future. I could have them return a tuple of bool and Future, but that's a bit heavy. Instead it turns out we can very easily make them return void, which will simplify things. Differential Revision: [D28224476](https://our.internmc.facebook.com/intern/diff/D28224476/) [ghstack-poisoned]
…f bool" Some methods are currently returning bool, but I'll soon want them to return a Future. I could have them return a tuple of bool and Future, but that's a bit heavy. Instead it turns out we can very easily make them return void, which will simplify things. Differential Revision: [D28224476](https://our.internmc.facebook.com/intern/diff/D28224476/) [ghstack-poisoned]
This was referenced May 17, 2021
mrshenli
approved these changes
May 18, 2021
Comment on lines
158
to
160
| "Return value of a builtin operator or a " | ||
| "TorchScript function should be a single IValue, got a vector of " | ||
| "size ", |
There was a problem hiding this comment.
nit: these can fit in two lines?
There was a problem hiding this comment.
Please feel free to update this in followup PRs. I don't want to make you rebase and wait for another 6H, just for these little changes.
…f bool" Some methods are currently returning bool, but I'll soon want them to return a Future. I could have them return a tuple of bool and Future, but that's a bit heavy. Instead it turns out we can very easily make them return void, which will simplify things. Differential Revision: [D28224476](https://our.internmc.facebook.com/intern/diff/D28224476/) [ghstack-poisoned]
…f bool" Some methods are currently returning bool, but I'll soon want them to return a Future. I could have them return a tuple of bool and Future, but that's a bit heavy. Instead it turns out we can very easily make them return void, which will simplify things. Differential Revision: [D28224476](https://our.internmc.facebook.com/intern/diff/D28224476/) [ghstack-poisoned]
…f bool" Some methods are currently returning bool, but I'll soon want them to return a Future. I could have them return a tuple of bool and Future, but that's a bit heavy. Instead it turns out we can very easily make them return void, which will simplify things. Differential Revision: [D28224476](https://our.internmc.facebook.com/intern/diff/D28224476/) [ghstack-poisoned]
This was referenced May 20, 2021
…f bool" Some methods are currently returning bool, but I'll soon want them to return a Future. I could have them return a tuple of bool and Future, but that's a bit heavy. Instead it turns out we can very easily make them return void, which will simplify things. Differential Revision: [D28224476](https://our.internmc.facebook.com/intern/diff/D28224476/) [ghstack-poisoned]
dgl-intel
pushed a commit
to dgl-intel/pytorch
that referenced
this pull request
May 21, 2021
Pull Request resolved: pytorch#57849 Some methods are currently returning bool, but I'll soon want them to return a Future. I could have them return a tuple of bool and Future, but that's a bit heavy. Instead it turns out we can very easily make them return void, which will simplify things. ghstack-source-id: 129567061 Differential Revision: [D28224476](https://our.internmc.facebook.com/intern/diff/D28224476/)
|
This pull request has been merged in f94f1db. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Some methods are currently returning bool, but I'll soon want them to return a Future. I could have them return a tuple of bool and Future, but that's a bit heavy. Instead it turns out we can very easily make them return void, which will simplify things.
Differential Revision: D28224476