Skip to content

Enable atan2 & hypot for BFloat16 on CUDA #57905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

imaginary-person
Copy link
Contributor

Enable atan2 & hypot for BFloat16 on CUDA.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 9, 2021

💊 CI failures summary and remediations

As of commit 3e917cb (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@imaginary-person imaginary-person marked this pull request as draft May 9, 2021 03:22
@codecov
Copy link

codecov bot commented May 9, 2021

Codecov Report

Merging #57905 (3e917cb) into master (e8fb167) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #57905      +/-   ##
==========================================
- Coverage   76.83%   76.82%   -0.01%     
==========================================
  Files        1984     1984              
  Lines      197144   197144              
==========================================
- Hits       151471   151454      -17     
- Misses      45673    45690      +17     

@imaginary-person imaginary-person marked this pull request as ready for review May 10, 2021 19:49
@bdhirsh bdhirsh requested a review from ngimel May 10, 2021 22:04
@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 10, 2021
@facebook-github-bot
Copy link
Contributor

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ngimel merged this pull request in c4a486f.

krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request May 19, 2021
Summary:
Enable `atan2` & `hypot` for BFloat16 on CUDA.

Pull Request resolved: pytorch#57905

Reviewed By: agolynski

Differential Revision: D28393706

Pulled By: ngimel

fbshipit-source-id: e505e5f098d35e4f7417508443cb0fedf6562dd1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants