Enable cat wo conditionals iff cpu #58026
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cat-without-conditionals is a valuable optimization on CPU but on GPU it can generate invalid code since it may introduce allocations (i.e. extra kernel launches) Differential Revision: [D28347703](https://our.internmc.facebook.com/intern/diff/D28347703/) [ghstack-poisoned]
facebook-github-bot
added
oncall: jit
💊 CI failures summary and remediationsAs of commit 4c44150 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced May 11, 2021
Cat-without-conditionals is a valuable optimization on CPU but on GPU it can generate invalid code since it may introduce allocations (i.e. extra kernel launches) Differential Revision: [D28347703](https://our.internmc.facebook.com/intern/diff/D28347703/) [ghstack-poisoned]
Cat-without-conditionals is a valuable optimization on CPU but on GPU it can generate invalid code since it may introduce allocations (i.e. extra kernel launches) Differential Revision: [D28347703](https://our.internmc.facebook.com/intern/diff/D28347703/) [ghstack-poisoned]
|
This pull request has been merged in a88673e. |
dgl-intel
pushed a commit
to dgl-intel/pytorch
that referenced
this pull request
May 13, 2021
Pull Request resolved: pytorch#58026 Cat-without-conditionals is a valuable optimization on CPU but on GPU it can generate invalid code since it may introduce allocations (i.e. extra kernel launches) ghstack-source-id: 128748630 Differential Revision: [D28347703](https://our.internmc.facebook.com/intern/diff/D28347703/)
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Pull Request resolved: pytorch#58026 Cat-without-conditionals is a valuable optimization on CPU but on GPU it can generate invalid code since it may introduce allocations (i.e. extra kernel launches) ghstack-source-id: 128748630 Test Plan: predictor Reviewed By: navahgar Differential Revision: D28347703 fbshipit-source-id: f9e68cd7bcf5d316082ce8378ddf99f2d33fcc07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Cat-without-conditionals is a valuable optimization on CPU but on GPU
it can generate invalid code since it may introduce allocations (i.e. extra
kernel launches)
Differential Revision: D28347703