Skip to content

[PyTorch] Migrate all extant uses of build_binary_op to build_borrowing_binary_op #58272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented May 13, 2021

Stack from ghstack:

Borrowing is more efficient, and structured kernels can always borrow.

Differential Revision: D28427768

…ng_binary_op

Borrowing is more efficient, and structured kernels can always borrow.

Differential Revision: [D28427768](https://our.internmc.facebook.com/intern/diff/D28427768/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 13, 2021

💊 CI failures summary and remediations

As of commit d91e7c7 (more details on the Dr. CI page):



1 failure not recognized by patterns:

Job Step Action
GitHub Actions flake8-py3 Unknown 🔁 rerun

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_linux_bionic_cuda10_2_cudnn7_py3_9_gcc7_test2 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun) ❄️

May 14 18:48:27 unknown file: Failure
May 14 18:48:27 frame #7: <unknown function> + 0x899e25 (0x55dca3c98e25 in build/bin/test_api)
May 14 18:48:27 frame #8: <unknown function> + 0x89a0d5 (0x55dca3c990d5 in build/bin/test_api)
May 14 18:48:27 frame #9: testing::internal::UnitTestImpl::RunAllTests() + 0xc1c (0x55dca3c9a12c in build/bin/test_api)
May 14 18:48:27 frame #10: testing::UnitTest::Run() + 0x98 (0x55dca3c9a3f8 in build/bin/test_api)
May 14 18:48:27 frame #11: main + 0xc8 (0x55dca361ede8 in build/bin/test_api)
May 14 18:48:27 frame #12: __libc_start_main + 0xe7 (0x7f473e684bf7 in /lib/x86_64-linux-gnu/libc.so.6)
May 14 18:48:27 frame #13: _start + 0x2a (0x55dca3654cca in build/bin/test_api)
May 14 18:48:27 " thrown in the test body.
May 14 18:48:27 [  FAILED  ] IntegrationTest.MNIST_CUDA (4 ms)
May 14 18:48:27 [ RUN      ] IntegrationTest.MNISTBatchNorm_CUDA
May 14 18:48:27 unknown file: Failure
May 14 18:48:27 C++ exception with description "Error opening images file at test/cpp/api/mnist/train-images-idx3-ubyte
May 14 18:48:27 Exception raised from read_images at /var/lib/jenkins/workspace/torch/csrc/api/src/data/datasets/mnist.cpp:67 (most recent call first):
May 14 18:48:27 frame #0: c10::Error::Error(c10::SourceLocation, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) + 0x6b (0x7f473ee44b6b in /var/lib/jenkins/workspace/build/lib/libc10.so)
May 14 18:48:27 frame #1: c10::detail::torchCheckFail(char const*, char const*, unsigned int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) + 0xce (0x7f473ee4084e in /var/lib/jenkins/workspace/build/lib/libc10.so)
May 14 18:48:27 frame #2: <unknown function> + 0x4065fe5 (0x7f475248afe5 in /var/lib/jenkins/workspace/build/lib/libtorch_cpu.so)
May 14 18:48:27 frame #3: torch::data::datasets::MNIST::MNIST(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, torch::data::datasets::MNIST::Mode) + 0x46 (0x7f475248c006 in /var/lib/jenkins/workspace/build/lib/libtorch_cpu.so)
May 14 18:48:27 frame #4: IntegrationTest_MNISTBatchNorm_CUDA_Test::TestBody() + 0x9de (0x55dca381a69e in build/bin/test_api)
May 14 18:48:27 frame #5: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 0x4a (0x55dca3ca211a in build/bin/test_api)
May 14 18:48:27 frame #6: <unknown function> + 0x899815 (0x55dca3c98815 in build/bin/test_api)
May 14 18:48:27 frame #7: <unknown function> + 0x899e25 (0x55dca3c98e25 in build/bin/test_api)

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

…ild_borrowing_binary_op"

Borrowing is more efficient, and structured kernels can always borrow.

Differential Revision: [D28427768](https://our.internmc.facebook.com/intern/diff/D28427768/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 8a4a511.

@facebook-github-bot facebook-github-bot deleted the gh/swolchok/231/head branch May 22, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants