[1/n] [c10d] Introduce a new TCPStore constructor #58328
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is part of a stack that addresses the GitHub issue #41614; it introduces a new `TCPStore` constructor that takes its optional parameters via a newly introduced `TCPStoreOptions` structure. This gives the API callers the flexibility to specify only the desired options while skipping the rest. The main motivation behind this change is the introduction of the `multiTenant` constructor option in the second PR of this stack. Differential Revision: [D28417742](https://our.internmc.facebook.com/intern/diff/D28417742/) [ghstack-poisoned]
cbalioglu
requested review from
H-Huang,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma,
wayi1 and
zhaojuanmao
as code owners
facebook-github-bot
added
oncall: distributed
💊 CI failures summary and remediationsAs of commit b977dcb (more details on the Dr. CI page):
3 failures not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced May 14, 2021
This PR is part of a stack that addresses the GitHub issue #41614; it introduces a new `TCPStore` constructor that takes its optional parameters via a newly introduced `TCPStoreOptions` structure. This gives the API callers the flexibility to specify only the desired options while skipping the rest. The main motivation behind this change is the introduction of the `multiTenant` constructor option in the second PR of this stack. Differential Revision: [D28417742](https://our.internmc.facebook.com/intern/diff/D28417742/) [ghstack-poisoned]
rohan-varma
approved these changes
May 19, 2021
This PR is part of a stack that addresses the GitHub issue #41614; it introduces a new `TCPStore` constructor that takes its optional parameters via a newly introduced `TCPStoreOptions` structure. This gives the API callers the flexibility to specify only the desired options while skipping the rest. The main motivation behind this change is the introduction of the `multiTenant` constructor option in the second PR of this stack. Differential Revision: [D28417742](https://our.internmc.facebook.com/intern/diff/D28417742/) [ghstack-poisoned]
This PR is part of a stack that addresses the GitHub issue #41614; it introduces a new `TCPStore` constructor that takes its optional parameters via a newly introduced `TCPStoreOptions` structure. This gives the API callers the flexibility to specify only the desired options while skipping the rest. The main motivation behind this change is the introduction of the `multiTenant` constructor option in the second PR of this stack. Differential Revision: [D28417742](https://our.internmc.facebook.com/intern/diff/D28417742/) [ghstack-poisoned]
This PR is part of a stack that addresses the GitHub issue #41614; it introduces a new `TCPStore` constructor that takes its optional parameters via a newly introduced `TCPStoreOptions` structure. This gives the API callers the flexibility to specify only the desired options while skipping the rest. The main motivation behind this change is the introduction of the `multiTenant` constructor option in the second PR of this stack. Differential Revision: [D28417742](https://our.internmc.facebook.com/intern/diff/D28417742/) [ghstack-poisoned]
This PR is part of a stack that addresses the GitHub issue #41614; it introduces a new `TCPStore` constructor that takes its optional parameters via a newly introduced `TCPStoreOptions` structure. This gives the API callers the flexibility to specify only the desired options while skipping the rest. The main motivation behind this change is the introduction of the `multiTenant` constructor option in the second PR of this stack. Differential Revision: [D28417742](https://our.internmc.facebook.com/intern/diff/D28417742/) [ghstack-poisoned]
This PR is part of a stack that addresses the GitHub issue #41614; it introduces a new `TCPStore` constructor that takes its optional parameters via a newly introduced `TCPStoreOptions` structure. This gives the API callers the flexibility to specify only the desired options while skipping the rest. The main motivation behind this change is the introduction of the `multiTenant` constructor option in the second PR of this stack. Differential Revision: [D28417742](https://our.internmc.facebook.com/intern/diff/D28417742/) [ghstack-poisoned]
|
This pull request has been merged in cf408c3. |
deniskokarev
pushed a commit
to deniskokarev/pytorch
that referenced
this pull request
Jun 9, 2021
Summary: Pull Request resolved: pytorch#58328 This PR is part of a stack that addresses the GitHub issue pytorch#41614; it introduces a new `TCPStore` constructor that takes its optional parameters via a newly introduced `TCPStoreOptions` structure. This gives the API callers the flexibility to specify only the desired options while skipping the rest. The main motivation behind this change is the introduction of the `multiTenant` constructor option in the second PR of this stack. ghstack-source-id: 130676384 Test Plan: Run the existing tests since there are no behavioral changes. Reviewed By: H-Huang Differential Revision: D28417742 fbshipit-source-id: e6ac2a057f7ad1908581176ee6d2c2554c3c74a9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR is part of a stack that addresses the GitHub issue #41614; it introduces a new
TCPStoreconstructor that takes its optional parameters via a newly introducedTCPStoreOptionsstructure. This gives the API callers the flexibility to specify only the desired options while skipping the rest.The main motivation behind this change is the introduction of the
multiTenantconstructor option in the second PR of this stack.Differential Revision: D28417742