Port kthvalue tests to OpInfo
#58654
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit e84d8bd (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
soulitzer
added
the
triaged
Codecov Report
@@ Coverage Diff @@
## master #58654 +/- ##
=======================================
Coverage 76.51% 76.51%
=======================================
Files 1992 1992
Lines 200145 200150 +5
=======================================
+ Hits 153134 153144 +10
+ Misses 47011 47006 -5 |
mruberry
reviewed
May 23, 2021
| @@ -61,7 +62,7 @@ inline void _reduction_with_indices_allocate_or_resize_output( | |||
| // unsqueeze to preserve passed in noncontiguous tensor in resize | |||
| values.unsqueeze_(dim); | |||
| } | |||
| values.resize_(result_sizes); | |||
| resize_output(values, result_sizes); | |||
mruberry
approved these changes
May 23, 2021
|
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue #54261