OpInfo: renorm #59079
Closed
OpInfo: renorm #59079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 33621e6 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
mruberry
reviewed
May 29, 2021
| dtypesIfCUDA=floating_types_and(torch.float16), | ||
| sample_inputs_func=sample_inputs_renorm, | ||
| skips=( | ||
| # AssertionError: Resized a non-empty tensor but did not warn about it. |
There was a problem hiding this comment.
I guess this isn't simple to fix because renorm is still in TH?
mruberry
reviewed
May 29, 2021
| @@ -1040,6 +1040,21 @@ def sample_inputs_trace(self, device, dtype, requires_grad, **kwargs): | |||
| requires_grad=requires_grad))),) | |||
|
|
|||
|
|
|||
| def sample_inputs_renorm(self, device, dtype, requires_grad, **kwargs): | |||
| make_arg = partial(make_tensor, dtype=dtype, device=device, requires_grad=requires_grad) | |||
| cases = (((S, S, S), (2, 1, 0.5)), | |||
There was a problem hiding this comment.
Note: we might want to start preserving names (where possible) now that SampleInputs have a "name" attribute
mruberry
approved these changes
May 29, 2021
|
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
deniskokarev
pushed a commit
to deniskokarev/pytorch
that referenced
this pull request
Jun 9, 2021
Summary: Reference: pytorch#54261 Pull Request resolved: pytorch#59079 Reviewed By: ngimel Differential Revision: D28776789 Pulled By: mruberry fbshipit-source-id: ca46f2debe918c3de1f3b5bbc9924b7ddfe9442a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #54261