OpInfo: div - port pending method_tests entry #59173
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 318b8b3 (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
kshitij12345
commented
May 31, 2021
kshitij12345
commented
May 31, 2021
mruberry
reviewed
May 31, 2021
mruberry
reviewed
May 31, 2021
There was a problem hiding this comment.
This looks pretty good @kshitij12345; I made a few comments inline for your review. Looking forward to porting one of the largest remaining set of method_tests()!
|
@mruberry Addressed the reviews. PTAL :) Changes
|
mruberry
reviewed
May 31, 2021
| @@ -739,7 +732,10 @@ def sample_inputs_linalg_vector_norm(op_info, device, dtype, requires_grad, **kw | |||
| # specify scalars of floating, integral & complex types as values for "alpha". | |||
| # Keyword argument `rhs_exclude_zero` is used to exclude zero values from rhs tensor argument | |||
| # This is necessary for operations like `true_divide`, where divide by zero throws an exception. | |||
| def sample_inputs_binary_pwise(op_info, device, dtype, requires_grad, **kwargs): | |||
| def sample_inputs_binary_pwise(op_info, device, dtype, requires_grad, extra_kwargs=None, **kwargs): | |||
There was a problem hiding this comment.
extra_kwargs is a better name
Style nit (only to be fixed if significant changes are required): make extra_kwargs keyword-only?
mruberry
reviewed
May 31, 2021
| @@ -1263,20 +1261,6 @@ def sample_inputs_comparison_ops(self, device, dtype, requires_grad, **kwargs): | |||
| sample_inputs = [*sample_inputs, *more_inputs] | |||
| return tuple(sample_inputs) | |||
|
|
|||
| def sample_inputs_div(self, device, dtype, requires_grad, rounding_mode=None, **kwargs): | |||
mruberry
reviewed
May 31, 2021
| sample_inputs_func=sample_inputs_div, | ||
| skips=(SkipInfo('TestOpInfo', 'test_duplicate_method_tests'),), | ||
| assert_autodiffed=True), | ||
| OpInfo('div', |
There was a problem hiding this comment.
Nice job noticing this was redundant
mruberry
reviewed
May 31, 2021
| @@ -6864,24 +6849,6 @@ def ident(x): | |||
| def method_tests(): | |||
| set_rng_seed(SEED) | |||
| return [ | |||
| ('div', (S, S, S), (torch.rand(S, S, S) + 0.1,), '', (True,)), | |||
mruberry
approved these changes
May 31, 2021
|
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
deniskokarev
pushed a commit
to deniskokarev/pytorch
that referenced
this pull request
Jun 9, 2021
Summary: Reference: pytorch#54261 Depends on: pytorch#59154 Pull Request resolved: pytorch#59173 Reviewed By: ngimel Differential Revision: D28785178 Pulled By: mruberry fbshipit-source-id: 902310f2d77e499a2355a23b2d5a8c0b21b8c5bb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #54261
Depends on: #59154